Repository navigation
Task file commands with pipe (|) in them don't fail #392
Description
Using task version 3
MacOS and Linux
When using a task that runs a command that includes a pipe (|) the task does not fail if the first part of the command fails.
Example Taskfile.yml
version: '3'
tasks:
pass:
cmds:
- exit 1 | echo "Hello"
fail:
cmds:
- exit 1Output:
task: exit 1 | echo "Hello"
Hello
task: exit 1
task: Failed to run task "fail": exit status 1It still doesn't fail the task if I call task from a script that sets pipefail
#!/usr/bin/env bash
set -eo pipefail
task pass << This doesn't fail when it should
task failI have also tried:
tasks:
pass:
cmds:
- set -e pipefail && exit 1 | echo "Hello"but still get the same result
I couldn't see anything in the documentation about changing this behaviour, so I guess it's a bug?
Activity
andreynering commentedon Dec 5, 2020
Hi @brodster2, thanks for opening this issue!
In my tests, the behavior of Bash and Task are the same:
exit 1 | echo "Hello"prints "Hello" without failing.Regarding
pipefail, you have a typo there:set -e pipefaildoes nothing, it should beset -o pipefail. When you do that, it works fine in Task as well.The only difference I found is that Bash support
set -eo pipefailwhile Task doesn not understand-eoat all. If you think that is a bug, I recommend you to open an issue in the Bash interpreter library that Task uses: https://github.com/mvdan/sh . Feel free to ping me there and mention this issue if you want.Hades32 commentedon May 30, 2022
@andreynering can you explain why this only works for single line scripts? I used your provided workaround successfully with
cmd1but withcmd2it continues executionghostsquad commentedon May 30, 2022
This is not a problem with Task directly. Please report https://github.com/mvdan/sh.
Notice also that there are other differences in your script, not just the lack of newline characters, but also the lack of semicolons.
This is definitely not a task specific problem though.
pinpox commentedon Nov 8, 2022
Is there a way to
set -e; set -o pipefailfor all cmd's?I want the task to stop if any of the cmd's fail, currently I have to set the bash options in front of everyone of them like so:
It would be nice to have the possiblity to do the
set -e -o pipefailonce for all of them. I tried this:But this seems to fully ignore the first cmd.