Improve shopt integration with mvdan/sh

We added support for set and shopt in #929. However, the implementation for shopt currently uses a workaround to prepend the shell options to each command before execution:

task/internal/execext/exec.go

Lines 75 to 85 in 73aba36

    
           // Run any shopt commands 
        
           if len(opts.BashOpts) > 0 { 
        
           	shoptCmdStr := fmt.Sprintf("shopt -s %s", strings.Join(opts.BashOpts, " ")) 
        
           	shoptCmd, err := parser.Parse(strings.NewReader(shoptCmdStr), "") 
        
           	if err != nil { 
        
           		return err 
        
           	} 
        
           	if err := r.Run(ctx, shoptCmd); err != nil { 
        
           		return err 
        
           	} 
        
           }

Ideally, we would pass Bash options using a new functional option interp.BashOpts and pass this into interp.New() like we do with set params.

mvdan/sh#962 tracks the upstream changes required to complete this.

Navigation Menu

Repository navigation

Improve shopt integration with mvdan/sh #984

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

	// Run any shopt commands
	if len(opts.BashOpts) > 0 {
	shoptCmdStr := fmt.Sprintf("shopt -s %s", strings.Join(opts.BashOpts, " "))
	shoptCmd, err := parser.Parse(strings.NewReader(shoptCmdStr), "")
	if err != nil {
	return err
	}
	if err := r.Run(ctx, shoptCmd); err != nil {
	return err
	}
	}

Improve shopt integration with mvdan/sh #984

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions