Fix spurious unary - overflow check in abs implementation - #1910
Merged
Merged
Conversation
Due to preconditions, this cannot overflow. But we also don't want the successful check from our internal implementation in the dashboard.
karoliineh
approved these changes
Jan 16, 2026
avsm
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Jun 15, 2026
CHANGES: * Add new may-happen-in-parallel analyses (goblint/analyzer#1805, goblint/analyzer#1865, goblint/analyzer#1913, goblint/analyzer#1928). * Add Open Verification Dashboard checks output (goblint/analyzer#1838, goblint/analyzer#1929). * Add negative bitwise shift warnings (goblint/analyzer#1637, goblint/analyzer#1989). * Add missing function declaration warnings (goblint/analyzer#1911). * Improve overflow warnings (goblint/analyzer#1894, goblint/analyzer#1895, goblint/analyzer#1896, goblint/analyzer#1905). * Fix spurious overflow checks (goblint/analyzer#1767, goblint/analyzer#1909, goblint/analyzer#1910, goblint/analyzer#1932, goblint/analyzer#2022). * Fix missing overflow and out-of-bounds checks (goblint/analyzer#1935, goblint/analyzer#2017, goblint/analyzer#2029). * Optimize base analysis domain using Patricia trees (goblint/analyzer#2002, goblint/analyzer#2015). * Optimize field offset calculations (goblint/analyzer#1964, goblint/analyzer#1973, goblint/analyzer#1974). * Optimize non-incremental top-down solver (goblint/analyzer#1566, goblint/analyzer#1972). * Add OCaml 5.5 support (goblint/analyzer#2006, goblint/analyzer#2010).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to preconditions, this cannot overflow.
But we also don't want the successful check from our internal implementation in the dashboard.