Skip to content
This repository was archived by the owner on Aug 29, 2024. It is now read-only.
This repository was archived by the owner on Aug 29, 2024. It is now read-only.

Cancel like terms is dependent of the order of factors in the numerator and denominator #232

Open

Description

@marpol2

step 1: (45 * 3)/(45 * 3)
step 2: 45 / 45
step 3: (1 * 45) / (1 * 45)
step 4: 1

while instead
step 1: (45 * 3)/(3 * 45)
step 2: (15 * 3) / 45
step 3: (1 * 3) / 3
step 4: 3 / 3
step 5: (1 * 3) / (1 * 3)
step 6: 1

This can probably be fixed by just adding a check before proceeding to "cancelTerms" in "cancelLikeTerms".

Activity

  1. evykassirer commented on Jan 20, 2018

    @evykassirer
    Contributor

    oh- good catch! thank so much :)

    I'm not prioritizing my time on writing code for mathsteps right now, but would be happy to review a change if you (or anyone else) puts one up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions