Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

Base transports w/ 'operations_client' have incorrect typing #1028

Closed
Closed
Base transports w/ 'operations_client' have incorrect typing#1028
Assignees
tseaver
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Description

@tseaver
tseaver
opened on Oct 13, 2021

From mypy:

google/cloud/datastore_admin_v1/services/datastore_admin/transports/grpc_asyncio.py:297: error: Return type "OperationsAsyncClient" of "operations_client" incompatible with return type "OperationsClient" in supertype "DatastoreAdminTransport"

The sync / async operations client types share no common base class (beyond object). The base transport shouldn't declare any typing at all.

Activity

  1. tseaver
    added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Oct 13, 2021
  2. tseaver
    self-assigned this
    on Oct 13, 2021
  3. tseaver
    added 2 commits that reference this issue on Oct 13, 2021

    fix: remove typing from base transport 'operations_client'

    85a26b9

    fix: remove typing from base transport 'operations_client'

    8dafd46
  4. tseaver
    closed this as completedin acb3ea8on Oct 13, 2021
  5. dizcology
    added a commit that references this issue on May 14, 2024

    fix: use correct typing for retries / operations_client (googleapis#1026

    acb3ea8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions