Generate common resource path helpers via google/cloud/common_resources.proto #586

Activity

1. busunkim96

   added

   type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.

   on Sep 3, 2020
2. vam-google

   added

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   generatorBugs, features, and so forth pertaining to the generated client surfaceBugs, features, and so forth pertaining to the generated client surface

   on Sep 8, 2020
3. software-dov commented on Sep 16, 2020

   

   software-dov

   on Sep 16, 2020

   Contributor

   More actions

   This should be straightforward and easy. There are a couple of potential gotchas:

   1. The path definitions in common_resources.proto don't have messages associated. This will require a little bit of rework in the generator logic and template.
   2. The correct thing to do would be to have common_resources.proto imported and then to use the descriptors to generate paths. I don't think we can do that by the time the generator plugin runs, so we'll need to just hack it in.
   3. There's a potential for name conflicts. One way to deal with this is to ignore it until a problem arises; another is to have a common disambiguation string, e.g. def common_project_path and def parse_common_project_path. Neither option seems great, but I'm leaning towards the second.

   What do other people think? @vam-google @busunkim96
4. software-dov

   linked a pull request that will close this issuefeat: add support for common resource paths #622on Sep 25, 2020
5. software-dov

   closed this as completedin #622on Sep 29, 2020
6. JustinBeckwith

   assigned

   software-dov

   on Feb 2, 2021