Skip to content
This repository was archived by the owner on Aug 25, 2026. It is now read-only.
This repository was archived by the owner on Aug 25, 2026. It is now read-only.

Generated tests for python-<API> are not complete #837

Closed

Description

@Shabirmean

The re-generated tests in some PRs are in-complete. This is related to the keyword policy being added to reserved names list, thus requiring a rename of the use of policy in the library to something like policy_

PR#50 of grafeas : Failing tests
PR#51 of grafeas : Failing tests
PR#18 of python-binary-authorization : Failing tests
PR#112 of python-containeranalysis : Failing tests
PR#12 of python-artifact-registry : Failing tests

Also related: #835

Activity

  1. added
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Apr 7, 2021
  2. changed the title [-]Generated tests for `python-binary-authorization` are not complete[/-] [+]Generated tests for `python-<API>` are not complete[/+] on Apr 7, 2021
  3. software-dov commented on Apr 21, 2021

    @software-dov
    Contributor

    @Shabirmean how serious would you say this issue is? Does it require immediate attention, or does it just block gapic regeneration?

  4. Shabirmean commented on Apr 21, 2021

    @Shabirmean
    Author

    @software-dov - I'd share the same as shared by @busunkim96 here.

    For the python-cloudbuild, python-artifact-registry and python-containeranalysis it seems like it's just the gapic regeneration. However for python-grafeas there are features that are not merged in due to this blocker.

  5. added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    and removed
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    🚨This issue needs some love.
    on May 10, 2021
  6. software-dov commented on Jan 27, 2022

    @software-dov
    Contributor

    Closing due to test coverage now being complete. Can reopen the issue if it resurfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions