delete deprecated fields of BundlingSettings by pongad · Pull Request #170 · googleapis/gax-java

pongad · 2017-01-10T03:22:32Z

Fixes #168.

This commit also performed branch elimination and constant propagation.
In particular:

All thresholds are required and therefore never null.
All limits are gone and therefore "always null".
BundlingThreshold::canAccept always return true,
and therefore deleted.

codecov-io · 2017-01-10T05:13:24Z

Current coverage is 71.12% (diff: 78.26%)

Merging #170 into master will increase coverage by 0.28%

@@             master       #170   diff @@
==========================================
  Files            61         61          
  Lines          2472       2455    -17   
  Methods           0          0          
  Messages          0          0          
  Branches        332        333     +1   
==========================================
- Hits           1751       1746     -5   
+ Misses          629        611    -18   
- Partials         92         98     +6

Powered by Codecov. Last update fd00034...a614fbb

Sign in to view

-     * and the simple API call will be used. Default to true.
-     */
-    public abstract Builder setIsEnabled(Boolean enabled);
-


Sign in to view

+          settings.getBlockingCallCountThreshold() > 0,
+          "blockingCallCountThreshold must be positive");
+      return settings;
    }


pongad · 2017-01-11T00:31:02Z

@garrettjonesgoogle PTAL

Fixes #168. This commit also performed branch elimination and constant propagation. In particular: All limits are gone and therefore "always null". BundlingThreshold::canAccept always return true, and therefore deleted.

Sign in to view

        BundlingSettings.newBuilder()
            .setDelayThreshold(Duration.standardSeconds(1))
            .setElementCountThreshold(2L)
-            .setBlockingCallCountThreshold(0L)


pongad · 2017-01-11T06:43:32Z

@garrettjonesgoogle PTAL

pongad · 2017-01-11T22:52:57Z

I'm stupid. PTAL

garrettjonesgoogle · 2017-01-11T23:03:25Z

LGTM

pongad assigned garrettjonesgoogle Jan 10, 2017

garrettjonesgoogle reviewed Jan 10, 2017

View reviewed changes

pongad changed the title ~~delete deprecated fields of BundlingSettings; make the rest required~~ delete deprecated fields of BundlingSettings Jan 11, 2017

delete deprecated fields of BundlingSettings

a5d0b52

Fixes #168. This commit also performed branch elimination and constant propagation. In particular: All limits are gone and therefore "always null". BundlingThreshold::canAccept always return true, and therefore deleted.

garrettjonesgoogle reviewed Jan 11, 2017

View reviewed changes

PR comment

a614fbb

PR comment

2e22e26

pongad merged commit 66d16f9 into googleapis:master Jan 11, 2017

pongad deleted the bundling-settings branch January 11, 2017 23:05

Conversation

pongad commented Jan 10, 2017

Uh oh!

codecov-io commented Jan 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 71.12% (diff: 78.26%)

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Jan 11, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Jan 11, 2017

Uh oh!

pongad commented Jan 11, 2017

Uh oh!

garrettjonesgoogle commented Jan 11, 2017

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-io commented Jan 10, 2017 •

edited

Loading