You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've gotten a lot of (non-breaking) features + lots of fixes out and released since 1.0.0... and we've nearly doubled our star count since it was released (!) I'm thinking about 1.1.0. If there's anything we're holding back on breaking that could/should be broken in 1.1.0 (for good reason of course) we'll have to figure that out before. Not sure what would like to be landed. Please use this bug to list your thoughts.
4xx (401 and 403 too) responses returned as errors instead of resp?
When constructing a client, make the version always separate, required parameter:
vardrive=google.drive('v2',{/* optional options here */})
Reasoning: I personally consider a good practice to lock the API version in my code so that when new version is released and made default, my code does not break. And the options object is optional, so it may make more sense that it only contains optional stuff.
This could be implemented as a non-breaking API change, by only printing some deprecation warnings to console.
We should probably somehow implement the automatic access token refreshing for 1.1.0 . If guys from the gcloud project could figure it out, we can do it, too!:)
If their solution would be too difficult or plain impossible to implement here (I am not familiar with that project so cannot really guess), maybe we can do it so that we only refresh the tokens when the request is not a streaming media upload, or something, as I understood that those are the cases where we are having issues.
Activity
robertrossmann commentedon Oct 20, 2014
When constructing a client, make the
versionalways separate, required parameter:Reasoning: I personally consider a good practice to lock the API version in my code so that when new version is released and made default, my code does not break. And the
optionsobject is optional, so it may make more sense that it only contains optional stuff.This could be implemented as a non-breaking API change, by only printing some deprecation warnings to console.
robertrossmann commentedon Oct 20, 2014
We should probably somehow implement the automatic access token refreshing for 1.1.0 . If guys from the gcloud project could figure it out, we can do it, too!:)
If their solution would be too difficult or plain impossible to implement here (I am not familiar with that project so cannot really guess), maybe we can do it so that we only refresh the tokens when the request is not a streaming media upload, or something, as I understood that those are the cases where we are having issues.
ryanseys commentedon Jan 12, 2015
Guess this is 1.2.0 now? haha
[-]1.1.0[/-][+]1.2.0[/+]JustinBeckwith commentedon Mar 13, 2016
We're about to release 3.0.0 in #532, so I think it's safe to close this :)