Skip to content

Bug when specifying media.body and providing refresh_token that needs refreshed. #332

Closed

Description

@benburkhart1

There's a bug in this client library when you try and do a file upload using the media.body property.

Here this expects the return value of authClient.request() to return something meaningful.

https://github.com/google/google-api-nodejs-client/blob/master/lib/apirequest.js#L203

Here's the actual request code, which does asynchronous callbacks, and does not return what this expects.

https://github.com/google/google-api-nodejs-client/blob/master/lib/auth/oauth2client.js#L241-L269

At the point in the first link, in my situation (provided refresh_token that needs refreshed), the returned req is 'undefined'.

Activity

  1. JustinBeckwith commented on Mar 15, 2018

    @JustinBeckwith
    Contributor

    Greetings! Since our switch to axios, I'm pretty sure this issue has been resolved. If you're still having problems - please do let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

🚨This issue needs some love.triage meI really want to be triaged.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions