Silent dependency on urllib3 in _aiohttp_requests #707

Activity

1. asafflesch commented on Feb 17, 2021

   

   asafflesch

   on Feb 17, 2021

   Author

   More actions

   (I see there's also a silent dependency there on requests - maybe you just intend for the exception on requests not being installed to go off first?)
2. yoshi-automation

   added

   triage meI really want to be triaged.I really want to be triaged.

   on Feb 18, 2021
3. busunkim96 commented on Feb 18, 2021

   

   busunkim96

   on Feb 18, 2021

   Contributor

   More actions

   Hey @FaQA,

   Before aiohttp_requests we didn't have urllib3 or requests as hard dependencies and assumed that folks would install one or both as needed after seeing one of these error messages:

   google-auth-library-python/google/auth/transport/requests.py

   Lines 25 to 35 in 65074d3

   	try:
   	import requests
   	except ImportError as caught_exc: # pragma: NO COVER
   	import six
   	six.raise_from(
   	ImportError(
   	"The requests library is not installed, please install the "
   	"requests package to use the requests transport."
   	),
   	caught_exc,

   google-auth-library-python/google/auth/transport/urllib3.py

   Lines 34 to 45 in 65074d3

   	try:
   	import urllib3
   	except ImportError as caught_exc: # pragma: NO COVER
   	import six
   	six.raise_from(
   	ImportError(
   	"The urllib3 library is not installed, please install the "
   	"urllib3 package to use the urllib3 transport."
   	),
   	caught_exc,
   	)

   Since _aiohttp_requests has a hard dependency on both I think we should just add it to the aiohttp extra to reduce friction. I'll open a PR adjusting the extras. After that change if you do pip install google-auth[aiohttp] it should pull in all the required dependencies.

   google-auth-library-python/setup.py

   Lines 32 to 35 in 65074d3

   	extras = {
   	"aiohttp": "aiohttp >= 3.6.2, < 4.0.0dev; python_version>='3.6'",
   	"pyopenssl": "pyopenssl>=20.0.0",
   	}

   👍React with 👍1Reacted by Asaf Flescher
4. busunkim96

   added

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   and removed

   triage meI really want to be triaged.I really want to be triaged.

   on Feb 18, 2021
5. parthea commented on May 19, 2021

   

   parthea

   on May 19, 2021

   Contributor

   More actions

   @busunkim96 Please can you take a look?
6. parthea

   assigned

   busunkim96

   on May 19, 2021
7. gcf-merge-on-green

   closed this as completedin #755on May 25, 2021
8. gcf-merge-on-green

   added a commit that references this issue on May 25, 2021

   fix(dependencies): add urllib3 and requests to aiohttp extra (#755)

   ...

   This issue will close once commit a923442 is merged into the 'main' branch.

   a923442