Skip to content

Automatically set the user-agent string on each request. #191

Closed

Description

@coryan

The client should set the user agent prefix in each request. Call the SetUserAgentPrefix() member function in the grpc::ChannelArguments before creating any channels in bigtable::DataClient or bigtable::AdminClient. The prefix should include the library version, e.g.,

auto prefix = absl::StrCat("cbt-cpp/", bigtable::major_version(), ".", bigtable::minor_version(), "-dev");

The "-dev" suffix should be (manually) removed when we create real release candidates. We should consider appending the output of

$ git rev-parse --short HEAD

to the user agent in dev versions. The output from git rev-parse that can be captured by cmake into
a generated .cc file.

Activity

  1. added this to the milestone on Jan 21, 2018
  2. added
    api: bigtableIssues related to the Bigtable API.
    and removed
    api: bigtableIssues related to the Bigtable API.
    on Jan 21, 2018
  3. self-assigned this
    on Jan 23, 2018
  4. added a commit that references this issue on Jan 23, 2018
    5278dc2
  5. added a commit that references this issue on Jan 23, 2018
    e485aaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨This issue needs some love.api: bigtableIssues related to the Bigtable API.triage meI really want to be triaged.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions