Repository navigation
Closed
Labels
api: bigtableIssues related to the Bigtable API.Issues related to the Bigtable API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Description
This is a rough breakdown of the tasks necessary to implement the new snapshot, replication, and IAM features in the Cloud Bigtable C++ client. In all cases the "Implement Foo" should be interpreted as "Implement any new wrappers needed for Foo, Implement the unit tests for Foo".
Needed for Beta:
- Update the googleapis to a version that includes these features (Update googleapis dependency. #218)
- Update the
Table::Tableconstructors to receive an optionalapp_profile_id. (Update Table::Table constructors to receive an optional app_profile_id #373) - Update the existing
Table::member functions to use theapp_profile_id. (Update the existing Table:: member functions to use the app_profile_id. #374) - Update the tests to verify the
app_profile_idis passed on to the RPC calls if set. (Update the tests to verify the app_profile_id is passed on to the RPC calls if set. #384) - Implement
TableAdmin::GenerateConsistencyToken - Implement
TableAdmin::CheckConsistency - Create a sample snippet that uses the
app_profile_id. - Create an integration test for
app_profile_id. - Wrap the
CheckConsistencyloop in the client library (Wrap TableAdmin::CheckConsistency in a loop. #426).
Not for Beta:
- Implement
TableAdmin::CreateTableFromSnapshot, return astd::future<>. - Implement
TableAdmin::CreateTableFromSnapshot, returnvoidand take a functor as argument. - Implement
TableAdmin::SnapshotTable, return astd::future<>. - Implement
TableAdmin::SnapshotTable, returnvoidand take a functor as argument. - Implement
TableAdmin::GetSnapshot. - Implement
TableAdmin::ListSnapshots. - Implement
TableAdmin::DeleteSnapshot. - Create a sample snippet for
TableAdmin::CreateTableFromSnapshot. - Create a sample snippet for
TableAdmin::SnapshotTablereturningstd::future<>. - Create a sample snippet for
TableAdmin::SnapshotTableusing a functor. - Create a sample snippet for
TableAdmin::GetSnapshot. - Create a sample snippet for
TableAdmin::ListSnapshots. - Create a sample snippet for
TableAdmin::DeleteSnapshot. - Create an integration test for
TableAdmin::CreateTableFromSnapshot. - Create an integration test for
TableAdmin::SnapshotTablereturningstd::future<>. - Create an integration test for
TableAdmin::SnapshotTableusing a functor. - Create an integration test for
TableAdmin::GetSnapshot. - Create an integration test for
TableAdmin::ListSnapshots. - Create an integration test for
TableAdmin::DeleteSnapshot. - Create bugs for each one of the items in this list.
Metadata
Metadata
Assignees
Labels
api: bigtableIssues related to the Bigtable API.Issues related to the Bigtable API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Activity
coryan commentedon Apr 9, 2018
For the record, @paprat created a breakdown for all the tasks to "implement X". I have created additional tasks for the integration tests and for sample snippets.
mbrukman commentedon Jul 6, 2018
@coryan, @paprat: are there other issues created for the following beta-blocker items from the list above?
I can't find them, but maybe I'm not searching correctly.
An example of using application profiles.
An example of using application profiles.
coryan commentedon Jul 7, 2018
@mbrukman I do not think you are "searching incorrectly", we never wrote them, just sent a PR (#850) with an example. Unfortunately I do not know how to write a (meaningful) integration test. The golang-based emulator ignores the application profile, so we can pass garbage, or nothing, and it would work. I guess we could extend the C++-based emulator to emulate the table admin and data admin APIs, but that is a lot of work for just one API (and not necessarily a great idea). And using both in the same test is impossible (and they ignore each other, so it does not help anyway).
An example of using application profiles.
An example of using application profiles.
An example of using application profiles. (#850)
coryan commentedon Aug 29, 2018
I am going to break this down into smaller bugs and then close it.
Implement integration test for Snapshot CRUD operations #1052: integration tests for snapshot CRUD operations.
Create an integration test to verify CreateSnapshot/CreateTableFromSnapshot work. #1053: integration test for CreateTableFromSnapshot.
Create an integration test for CheckConsistency* functions. #1054: integration tests for CreateConsistencyToken and friends.
Implement a sample snippet for TableAdmin::GetSnapshot. #1055: sample for GetSnapshot.
Implement sample snippet for TableAdmin::DeleteSnapshot #1056: Implement sample snippet for TableAdmin::DeleteSnapshot
Implement sample snippet for TableAdmin::CreateTableFromSnapshot #1057: Implement sample snippet for TableAdmin::CreateTableFromSnapshot
Implement sample snippet for TableAdmin::ListSnapshots #1058: Implement sample snippet for TableAdmin::ListSnapshots
Implement sample snippet for TableAdmin::GenerateConsistencyToken #1059: Implement sample snippet for TableAdmin::GenerateConsistencyToken
Implement sample snippet for TableAdmin::CheckConsistency #1060: Implement sample snippet for TableAdmin::CheckConsistency
Implement sample snippet for TableAdmin::WaitForConsistencyCheck #1061: Implement sample snippet for TableAdmin::WaitForConsistencyCheck
Implement TableAdmin::SnapshotTable. #379: Implement Table::SnapshotTable.
I am not going to create bugs for the async / functor functions. Better to delay that until we start that project.