Skip to content

Implement new snapshot and replication APIs in the Cloud Bigtable C++ client #329

Closed

Description

@coryan

This is a rough breakdown of the tasks necessary to implement the new snapshot, replication, and IAM features in the Cloud Bigtable C++ client. In all cases the "Implement Foo" should be interpreted as "Implement any new wrappers needed for Foo, Implement the unit tests for Foo".

Needed for Beta:

Not for Beta:

  • Implement TableAdmin::CreateTableFromSnapshot, return a std::future<>.
  • Implement TableAdmin::CreateTableFromSnapshot, return void and take a functor as argument.
  • Implement TableAdmin::SnapshotTable, return a std::future<>.
  • Implement TableAdmin::SnapshotTable, return void and take a functor as argument.
  • Implement TableAdmin::GetSnapshot.
  • Implement TableAdmin::ListSnapshots.
  • Implement TableAdmin::DeleteSnapshot.
  • Create a sample snippet for TableAdmin::CreateTableFromSnapshot.
  • Create a sample snippet for TableAdmin::SnapshotTable returning std::future<>.
  • Create a sample snippet for TableAdmin::SnapshotTable using a functor.
  • Create a sample snippet for TableAdmin::GetSnapshot.
  • Create a sample snippet for TableAdmin::ListSnapshots.
  • Create a sample snippet for TableAdmin::DeleteSnapshot.
  • Create an integration test for TableAdmin::CreateTableFromSnapshot.
  • Create an integration test for TableAdmin::SnapshotTable returning std::future<>.
  • Create an integration test for TableAdmin::SnapshotTable using a functor.
  • Create an integration test for TableAdmin::GetSnapshot.
  • Create an integration test for TableAdmin::ListSnapshots.
  • Create an integration test for TableAdmin::DeleteSnapshot.
  • Create bugs for each one of the items in this list.

Activity

  1. added this to the milestone on Mar 20, 2018
  2. self-assigned this
    on Mar 27, 2018
  3. coryan commented on Apr 9, 2018

    @coryan
    ContributorAuthor

    For the record, @paprat created a breakdown for all the tasks to "implement X". I have created additional tasks for the integration tests and for sample snippets.

  4. removed this from the milestone on Apr 11, 2018
  5. mbrukman commented on Jul 6, 2018

    @mbrukman
    Contributor

    @coryan, @paprat: are there other issues created for the following beta-blocker items from the list above?

    • Create a sample snippet that uses the app_profile_id.
    • Create an integration test for app_profile_id.

    I can't find them, but maybe I'm not searching correctly.

  6. self-assigned this
    on Jul 7, 2018
  7. coryan commented on Jul 7, 2018

    @coryan
    ContributorAuthor

    @mbrukman I do not think you are "searching incorrectly", we never wrote them, just sent a PR (#850) with an example. Unfortunately I do not know how to write a (meaningful) integration test. The golang-based emulator ignores the application profile, so we can pass garbage, or nothing, and it would work. I guess we could extend the C++-based emulator to emulate the table admin and data admin APIs, but that is a lot of work for just one API (and not necessarily a great idea). And using both in the same test is impossible (and they ignore each other, so it does not help anyway).

  8. added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    on Jul 11, 2018
  9. removed their assignment
    on Aug 3, 2018
  10. self-assigned this
    on Aug 29, 2018
  11. coryan commented on Aug 29, 2018

    @coryan
    ContributorAuthor

    I am going to break this down into smaller bugs and then close it.

    I am not going to create bugs for the async / functor functions. Better to delay that until we start that project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: bigtableIssues related to the Bigtable API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions