Skip to content

Avoid copying in Table::ReadModifyWrite. #336

Closed

Description

@hemant-qlogic

The code below could cause the performance issue when a large number of ReadModifyWriteRules are applied to the table.

bigtable/client/table.h
*request.add_rules() = rule.as_proto_move();
This need to be handle properly to remove the performance issue.

Activity

  1. changed the title [-]ReadModifyWriteRowRequest::add_rules makes the copy of the ReadModifyWriteRule objects may cause performance issue for large rules[/-] [+]Avoid copying in Table::ReadModifyWrite.[/+] on Mar 16, 2018
  2. added
    good first issueThis issue is a good place to started contributing to this repository.
    api: bigtableIssues related to the Bigtable API.
    on Mar 16, 2018
  3. coryan commented on Mar 16, 2018

    @coryan
    Contributor

    To rephrase that in more general terms: Table::ReadModifyWrite() has some data copying in the current implementation. We do not expect this to be a big problem, but this is a nice optimization to do in the future.

  4. added
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    on Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: bigtableIssues related to the Bigtable API.good first issueThis issue is a good place to started contributing to this repository.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions