Repository navigation
Conversation
…f creating admin and clients objects
Codecov Report
@@ Coverage Diff @@
## master #1177 +/- ##
==========================================
+ Coverage 91.93% 91.94% +0.01%
==========================================
Files 220 220
Lines 12169 12197 +28
==========================================
+ Hits 11188 11215 +27
- Misses 981 982 +1
Continue to review full report at Codecov.
|
coryan
left a comment
There was a problem hiding this comment.
Lots of nits about code formatting and avoiding some repetition. Otherwise good.
| * | ||
| * @par Cost | ||
| * Applications should avoid unnecessarily creating new objects of type | ||
| * AdminClient. Creating a new object of this type typically requires connecting |
There was a problem hiding this comment.
Please you use AdminClient make it look like code in the docs.
| * | ||
| * @par Cost | ||
| * Creating a new object of type InstanceAdmin is comparable to creating a few | ||
| * objects of type std::string or a few objects of type std::shared_ptr<int>. |
There was a problem hiding this comment.
Same thing here about formatting.
| * | ||
| * @param instance_config a description of the new instance to be created. | ||
| * instance_id and a display_name parameters must be set in instance_config, | ||
| * - instance_id : instance_id must be between 6 and 33 characters. |
There was a problem hiding this comment.
I think we can just say:
* - instance_id : must be between 6 and 33 characters.
no need to repeat instance_id, sample thing with display_name.
| * | ||
| * @par Cost | ||
| * Creating a new object of type Table is comparable to creating a few objects | ||
| * of type std::string or a few objects of type std::shared_ptr<int>. The class |
There was a problem hiding this comment.
Same comment about code formatting.
|
PTAL |
Documenting instance id, name and cluster id length limits and cost of creating admin and clients objects.
This fixes #802 and #480
This change is