Skip to content

Implement missing example for CheckAndMutate. - #2611

Merged
coryan merged 1 commit into
googleapis:masterfrom
coryan:check-and-mutate-if-not-exist
May 6, 2019
Merged

coryan merged 1 commit into
googleapis:masterfrom
coryan:check-and-mutate-if-not-exist

Conversation

@coryan

@coryan coryan commented May 5, 2019 •

Copy link
Copy Markdown
Contributor

Implement an example of CheckAndMutate that modifies a cell if another
cell does not exist. This was a long outstanding bug (#1190). In the
process to fix this I removed a number of hard-coded row keys, fixing (I
think) #2404.

This fixes #1190 and fixes #2404.


This change is Reviewable

Implement an example of CheckAndMutate that modifies a cell if another
cell does *not* exist. This was a long outstanding bug (googleapis#1190). In the
process to fix this I removed a number of hard-coded row keys, fixing (I
think) googleapis#2404.
@coryan coryan added the api: bigtable Issues related to the Bigtable API. label May 5, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2019
@codecov

codecov Bot commented May 5, 2019

Copy link
Copy Markdown

Codecov Report

Merging #2611 into master will increase coverage by 0.01%.
The diff coverage is 97.91%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2611      +/-   ##
=========================================
+ Coverage   93.29%   93.3%   +0.01%     
=========================================
  Files         309     309              
  Lines       20766   20783      +17     
=========================================
+ Hits        19374   19392      +18     
+ Misses       1392    1391       -1
Impacted Files Coverage Δ
google/cloud/bigtable/table.h 100% <ø> (ø) ⬆️
...gle/cloud/bigtable/examples/data_async_snippets.cc 91.12% <100%> (-0.08%) ⬇️
google/cloud/bigtable/examples/data_snippets.cc 90.84% <97.14%> (+0.46%) ⬆️
...storage/benchmarks/storage_throughput_benchmark.cc 82.85% <0%> (-0.36%) ⬇️
google/cloud/storage/internal/parse_rfc3339.cc 98.88% <0%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fe0cd3...e0cbfa1. Read the comment docs.

@coryan
coryan requested review from devbww, devjgm, mr-salty and scotthart May 6, 2019 16:11
@coryan
coryan merged commit d89aab1 into googleapis:master May 6, 2019
@coryan
coryan deleted the check-and-mutate-if-not-exist branch May 6, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove magic row keys from Bigtable samples. Document "Use CheckAndMutate to modify a value if the other value does not exist"

3 participants