Skip to content

feat(firestore): global option to turn on implicit orderby - #7641

Merged
wu-hui merged 3 commits into
mainfrom
feat-implicit-orderby
Mar 19, 2026
Merged

wu-hui merged 3 commits into
mainfrom
feat-implicit-orderby

Conversation

@wu-hui

@wu-hui wu-hui commented Mar 17, 2026 •

Copy link
Copy Markdown
Contributor

@ghost
ghost self-requested a review as a code owner March 17, 2026 15:26
@ghost ghost added the api: firestore Issues related to the Firestore API. label Mar 17, 2026
@ghost
ghost force-pushed the feat-implicit-orderby branch from f565d1f to ad6901a Compare March 17, 2026 15:47
@ghost
ghost self-requested a review as a code owner March 17, 2026 15:47
@ghost
ghost force-pushed the feat-implicit-orderby branch from 3510568 to f40a641 Compare March 17, 2026 20:11
@ghost
ghost force-pushed the feat-implicit-orderby branch from f40a641 to 7b85096 Compare March 17, 2026 20:44
@ghost
ghost requested a review from MarkDuckworth March 17, 2026 22:29
@ghost ghost self-assigned this Mar 17, 2026

ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

openTelemetry?: FirestoreOpenTelemetryOptions;
/**
* Whether to always use implicit order by clauses.
* @internal

ghost Mar 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this @internal tag?

ghost Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

* Whether to always use implicit order by clauses.
* @internal
*/
get alwaysUseImplicitOrderBy(): boolean;

ghost Mar 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want this property on the Firestore API? And if so, did you intend to leave it internal?

ghost Mar 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ghost
ghost force-pushed the feat-implicit-orderby branch from b3db01e to 7857b40 Compare March 19, 2026 16:25
@ghost
ghost merged commit c9ae1d5 into main Mar 19, 2026
@ghost
ghost deleted the feat-implicit-orderby branch March 19, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants