This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Repository navigation
chore: Migrate talent synth.py to bazel - #100
Closed
vam-google wants to merge 0 commit into
Closed
vam-google wants to merge 0 commit into
vam-google wants to merge 0 commit into
Conversation
Contributor
Author
|
@chingor13 PTAL |
chingor13
suggested changes
Mar 20, 2020
| * @throws com.google.api.gax.rpc.ApiException if the remote call fails | ||
| */ | ||
| public final ListCompaniesPagedResponse listCompanies(ProjectName parent) { | ||
| public final ListCompaniesPagedResponse listCompanies(TenantName parent) { |
Contributor
There was a problem hiding this comment.
This looks like a resource name change and shouldn't be happening here.
chingor13
suggested changes
Mar 20, 2020
chingor13
left a comment
Contributor
There was a problem hiding this comment.
Let's just update the synth.py file and we'll resolve the resource name change in the subsequent PR.
For context, resource names are changing here during the migration from artman config yaml to proto annotations.
vam-google
added a commit
to vam-google/java-talent
that referenced
this pull request
Mar 23, 2020
As suggested in googleapis#100, this PR only updates the synth.py itself to use bazel. The updatged generated code will be published separately by yoshi, because it includes breaking changes in resource names, caused not by the bazel migration but by the chnages in the generator itself.
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Mar 23, 2020
As suggested in #100, this PR only updates the `synth.py` itself to use bazel. The updated generated code will be published separately by Yoshi, because it includes breaking changes in resource names, caused not by the bazel migration but by the changes in the generator itself.
yoshi-automation
added a commit
that referenced
this pull request
Mar 24, 2020
3c59df9 commit 3c59df9 Author: Vadym Matsishevskyi <25311427+vam-google@users.noreply.github.com> Date: Mon Mar 23 14:26:04 2020 -0700 chore: Migrate talent synth.py to bazel (#103) As suggested in #100, this PR only updates the `synth.py` itself to use bazel. The updated generated code will be published separately by Yoshi, because it includes breaking changes in resource names, caused not by the bazel migration but by the changes in the generator itself. synth.py
vam-google
added a commit
to vam-google/java-containeranalysis
that referenced
this pull request
Mar 24, 2020
As suggested in googleapis/java-talent#100, this PR only updates the synth.py itself to use bazel. The updatged generated code will be published separately by yoshi, because it includes breaking changes in resource names, caused not by the bazel migration but by the chnages in the generator itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in grpc stubs are caused by the gRPC upgrade from 1.10 (more than a year old) to 1.27 (same version which is used as runtime dependency)