This repository was archived by the owner on Feb 20, 2026. It is now read-only.
Repository navigation
feat: add options param to query#runStream - #611
Merged
Merged
Conversation
AVaksman
commented
Mar 9, 2020
Contributor
- Ensure the tests and linter pass
- Code coverage does not decrease (if any source code was changed)
- Appropriate docs were updated (if necessary)
Contributor
|
@AVaksman could you please explain the motivation of this PR and more about the changes? |
Contributor
Author
Sure export interface RunQueryOptions {
consistency?: 'strong' | 'eventual';
gaxOptions?: CallOptions;
wrapNumbers?: boolean | IntegerTypeCastOptions;
}in particular the |
stephenplusplus
suggested changes
Mar 24, 2020
Contributor
|
Ah, gothca. Thanks! I just had a small change request, but LGTM. |
stephenplusplus
approved these changes
Mar 27, 2020
yoshi-automation
added a commit
that referenced
this pull request
Apr 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.