Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

feat: add options param to query#runStream - #611

Merged
AVaksman merged 9 commits into
googleapis:masterfrom
AVaksman:query_runStream
Mar 30, 2020
Merged

AVaksman merged 9 commits into
googleapis:masterfrom
AVaksman:query_runStream

Conversation

@AVaksman

@AVaksman AVaksman commented Mar 9, 2020

Copy link
Copy Markdown
Contributor
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2020
@stephenplusplus

Copy link
Copy Markdown
Contributor

@AVaksman could you please explain the motivation of this PR and more about the changes?

@AVaksman

Copy link
Copy Markdown
Contributor Author

@AVaksman could you please explain the motivation of this PR and more about the changes?

Sure
query.runStream() delegates to request.runQueryStream() and typescript users don't have an ability to pass options

export interface RunQueryOptions {
  consistency?: 'strong' | 'eventual';
  gaxOptions?: CallOptions;
  wrapNumbers?: boolean | IntegerTypeCastOptions;
}

in particular the wrapNumbers value, leaving the user no way to handle out of bounds integers.

@bcoe
bcoe requested a review from stephenplusplus March 24, 2020 03:37
Comment thread system-test/datastore.ts Resolved
@stephenplusplus

Copy link
Copy Markdown
Contributor

Ah, gothca. Thanks! I just had a small change request, but LGTM.

@AVaksman
AVaksman merged commit 7429c9d into googleapis:master Mar 30, 2020
yoshi-automation added a commit that referenced this pull request Apr 1, 2020
7429c9d
commit 7429c9d
Author: Alex <7764119+AVaksman@users.noreply.github.com>
Date:   Mon Mar 30 12:28:22 2020 -0400

    feat: add options param to query#runStream (#611)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants