Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

fix: missing await in rollback - #671

Merged
bcoe merged 3 commits into
googleapis:masterfrom
laljikanjareeya:fix-missing-await
May 27, 2020
Merged

bcoe merged 3 commits into
googleapis:masterfrom
laljikanjareeya:fix-missing-await

Conversation

@laljikanjareeya

Copy link
Copy Markdown
Contributor

Fixes #668

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2020
@codecov

codecov Bot commented May 18, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #671 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
- Coverage   99.36%   99.35%   -0.02%     
==========================================
  Files           7        7              
  Lines        6159     6171      +12     
  Branches      383      386       +3     
==========================================
+ Hits         6120     6131      +11     
- Misses         38       39       +1     
  Partials        1        1              
Impacted Files Coverage Δ
src/request.ts 100.00% <100.00%> (ø)
src/index.ts 99.70% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e157c...8638d97. Read the comment docs.

@laljikanjareeya laljikanjareeya added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 19, 2020
Comment thread src/request.ts Resolved
Comment thread src/request.ts Resolved
@laljikanjareeya

Copy link
Copy Markdown
Contributor Author

@AVaksman It shows code coverage decrease in src/index.ts but, there is not change on that file.

@laljikanjareeya
laljikanjareeya requested a review from AVaksman May 21, 2020 16:16
@laljikanjareeya

Copy link
Copy Markdown
Contributor Author

@AVaksman Addressed all the comments please take a look!!

@bcoe
bcoe merged commit 7cb353e into googleapis:master May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transaction rollback is missing await

6 participants