Skip to content
This repository was archived by the owner on Feb 20, 2026. It is now read-only.

fix(deps): update dependency sinon to v10 - #810

Merged
bcoe merged 2 commits into
googleapis:masterfrom
renovate-bot:renovate/sinon-10.x
Apr 29, 2021
Merged

bcoe merged 2 commits into
googleapis:masterfrom
renovate-bot:renovate/sinon-10.x

Conversation

@renovate-bot

@renovate-bot renovate-bot commented Mar 23, 2021 •

Copy link
Copy Markdown
Contributor

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sinon (source) ^9.0.0 -> ^10.0.0 age adoption passing confidence
sinon (source) ^9.0.1 -> ^10.0.0 age adoption passing confidence
@types/sinon ^9.0.0 -> ^10.0.0 age adoption passing confidence

Release Notes

sinonjs/sinon

v10.0.0

Compare Source

==================


Configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot
renovate-bot requested a review from a team March 23, 2021 10:42
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2021
@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/nodejs-datastore API. label Mar 23, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2021
@sofisl sofisl added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Mar 23, 2021
@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Mar 23, 2021
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 31, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 31, 2021
@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2021
@tmatsuo

tmatsuo commented Apr 14, 2021

Copy link
Copy Markdown
Contributor

They are known flakes. Let me re-run the tests.

@tmatsuo tmatsuo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2021
@tmatsuo

tmatsuo commented Apr 15, 2021

Copy link
Copy Markdown
Contributor

Retry failed again. The error message is:

Error: 8 RESOURCE_EXHAUSTED: Too many currently active operations.

It might be possible that we have stale operations hanging so the test is consistently failing.

@tmatsuo tmatsuo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2021
@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 15, 2021
@tmatsuo

tmatsuo commented Apr 15, 2021

Copy link
Copy Markdown
Contributor

I manually deleted hanging operations. Let's retry once again.

@tmatsuo tmatsuo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2021
@tmatsuo

tmatsuo commented Apr 15, 2021

Copy link
Copy Markdown
Contributor

Hmm, even after manually deleted more than 10 operations, the API still lists 20 operations.

@tmatsuo

tmatsuo commented Apr 19, 2021

Copy link
Copy Markdown
Contributor

Those operations are still in CANCELLING state.

@tmatsuo

tmatsuo commented Apr 23, 2021

Copy link
Copy Markdown
Contributor

Internal issue: b/186233694

@trusted-contributions-gcf trusted-contributions-gcf Bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2021
@codecov

codecov Bot commented Apr 29, 2021 •

Copy link
Copy Markdown

Codecov Report

Merging #810 (1b10472) into master (e7a7179) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files          11       11           
  Lines        8255     8255           
  Branches      528      483   -45     
=======================================
  Hits         8170     8170           
  Misses         83       83           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a7179...1b10472. Read the comment docs.

@bcoe
bcoe merged commit 267992f into googleapis:master Apr 29, 2021
@renovate-bot
renovate-bot deleted the renovate/sinon-10.x branch April 29, 2021 00:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/nodejs-datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants