Unit tests are broken on master #829

Activity

1. product-auto-label

   added

   api: spannerIssues related to the googleapis/nodejs-spanner API.Issues related to the googleapis/nodejs-spanner API.

   on Feb 13, 2020
2. JustinBeckwith

   added

   priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.

   type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

   on Feb 13, 2020
3. JustinBeckwith

   assigned

   skuruppu

   on Feb 13, 2020
4. olavloite

   self-assigned this

   on Feb 13, 2020
5. olavloite commented on Feb 13, 2020

   

   olavloite

   on Feb 13, 2020

   Contributor

   More actions

   @skuruppu @JustinBeckwith I'll have a look right away.
6. olavloite commented on Feb 13, 2020

   

   olavloite

   on Feb 13, 2020

   Contributor

   More actions

   @JustinBeckwith @skuruppu @bcoe
   The problem appears to be related to Node version 12.16.0. I had 12.15.0 installed locally and could run all tests without problems. I've now installed 12.16.0 and get the error that is also showing up in the CI:

     1) Database
          "before each" hook for "should promisify all the things":
        TypeError: Cannot assign to read only property 'errorMonitor' of function 'class Database extends service_object_1.GrpcServiceObject {
       constructor(instance, name, poolOptions) {
       ...<omitted>...
   }'
         at setProperty (node_modules/extend/index.js:46:24)
         at extend (node_modules/extend/index.js:108:7)
         at Context.<anonymous> (test/database.ts:218:5)
         at processImmediate (internal/timers.js:456:21)
   
7. olavloite

   added a commit that references this issue on Feb 13, 2020

   deps: remove @types/extend

   ...

   This issue will close once commit 0798cea is merged into the 'master' branch.

   0798cea
8. JustinBeckwith

   closed this as completedin #830on Feb 14, 2020
9. bcoe commented on Feb 18, 2020

   

   bcoe

   on Feb 18, 2020

   More actions

   this was ultimately fixed in Node@12.16.1, just a fun note: https://nodejs.org/en/blog/release/v12.16.1/

   👍React with 👍3Reacted by Jordan Harband, Justin Beckwith and Knut Olav Løite