This repository was archived by the owner on Oct 20, 2026. It is now read-only.
Repository navigation
build!: drop node8 and convert to TypeScript - #888
Merged
Merged
Conversation
alexander-fenster
requested review from
AVaksman,
JustinBeckwith,
bcoe,
stephenplusplus,
summer-ji-eng and
xiaozhenliu-gg5
April 9, 2020 21:08
JustinBeckwith
approved these changes
Apr 9, 2020
JustinBeckwith
left a comment
Contributor
There was a problem hiding this comment.
LGTM assuming nits are addressed
xiaozhenliu-gg5
approved these changes
Apr 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
===========================================
+ Coverage 74.89% 97.51% +22.61%
===========================================
Files 44 22 -22
Lines 22386 18212 -4174
Branches 694 965 +271
===========================================
+ Hits 16766 17759 +993
+ Misses 5619 451 -5168
- Partials 1 2 +1
Continue to review full report at Codecov.
|
bcoe
approved these changes
Apr 10, 2020
bcoe
left a comment
There was a problem hiding this comment.
great work @alexander-fenster, this is truly looking like the home stretch.
| "eslint-plugin-prettier": "^3.0.0", | ||
| "gts": "^1.0.0", | ||
| "execa": "^4.0.0", | ||
| "gts": "2.0.0-alpha.9", |
There was a problem hiding this comment.
@JustinBeckwith if you give me broad strokes of what's needed, I might be able to help draft the migration guide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final library to be migrated to TypeScript generator! :)
Long story short:
gtsv2proto/folder in favor of auto-generatedprotos/folderOne code changes: in the manually written enums string values were used:
I'm getting rid of manually written types so this gets replaced with a real enum (with integer values), hence some smaller code changes in
src/codec.ts. Luckily,src/codec.tsis covered by tests really well, so (a) this problem was caught, and (b) I'm pretty confident in a fix.No changes to system tests or samples, which makes me feel really good :)