Skip to content
This repository was archived by the owner on Oct 20, 2026. It is now read-only.

fix: use DELETE FROM for consistency - #923

Merged
skuruppu merged 4 commits into
masterfrom
skuruppu-delete-samples-fix
May 8, 2020
Merged

skuruppu merged 4 commits into
masterfrom
skuruppu-delete-samples-fix

Conversation

@skuruppu

@skuruppu skuruppu commented Apr 24, 2020 •

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #922 🦕

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2020
@skuruppu skuruppu added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Apr 24, 2020
@skuruppu
skuruppu requested a review from olavloite April 24, 2020 04:59
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020

@laljikanjareeya laljikanjareeya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented May 4, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #923 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files          21       21           
  Lines       19959    19959           
  Branches     1069     1069           
=======================================
  Hits        19601    19601           
- Misses        354      355    +1     
+ Partials        4        3    -1     
Impacted Files Coverage Δ
src/backup.ts 99.40% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43765d8...a153b72. Read the comment docs.

@skuruppu skuruppu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2020
@skuruppu skuruppu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2020
@skuruppu
skuruppu removed the request for review from olavloite May 8, 2020 02:06
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2020
@skuruppu skuruppu added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels May 8, 2020
@skuruppu
skuruppu merged commit 0854c70 into master May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure DELETE FROM is used in code samples

5 participants