Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

fix: update getLabels definition to actually allow no arguments when … - #1559

Merged
ddelgrosso1 merged 1 commit into
googleapis:masterfrom
ddelgrosso1:fix-get-labels
Aug 26, 2021
Merged

fix: update getLabels definition to actually allow no arguments when …#1559
ddelgrosso1 merged 1 commit into
googleapis:masterfrom
ddelgrosso1:fix-get-labels

Conversation

@ddelgrosso1

@ddelgrosso1 ddelgrosso1 commented Aug 26, 2021

Copy link
Copy Markdown
Contributor

…used in typescript

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1
ddelgrosso1 requested review from a team August 26, 2021 16:23
@product-auto-label product-auto-label Bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Aug 26, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2021
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 26, 2021
shaffeeullah
shaffeeullah approved these changes Aug 26, 2021
View reviewed changes

@shaffeeullah shaffeeullah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks Denis!

@ddelgrosso1
ddelgrosso1 merged commit 176dbb5 into googleapis:master Aug 26, 2021
@ddelgrosso1
ddelgrosso1 deleted the fix-get-labels branch August 26, 2021 17:29
gcf-merge-on-green Bot pushed a commit that referenced this pull request Aug 26, 2021
@release-please
chore: release 5.13.2 (#1560)
6cefbc6 
🤖 I have created a release \*beep\* \*boop\*
---
### [5.13.2](https://www.github.com/googleapis/nodejs-storage/compare/v5.13.1...v5.13.2) (2021-08-26)


### Bug Fixes

* update getLabels definition to actually allow no arguments when used in typescript ([#1559](https://www.github.com/googleapis/nodejs-storage/issues/1559)) ([176dbb5](https://www.github.com/googleapis/nodejs-storage/commit/176dbb5223f4442d10fd098ffa2cda5cf12144f2))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@shaffeeullah shaffeeullah shaffeeullah approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ddelgrosso1 @shaffeeullah