Repository navigation
fix: only check iat if nbf is not used - #493
Merged
Merged
Conversation
bshaffer
requested changes
May 3, 2023
bshaffer
left a comment
Collaborator
There was a problem hiding this comment.
If we did this, we would also want to support validation of the nbf claim
Author
Sorry i don't understand. The |
Collaborator
|
You're right, I didn't realize we were checking |
bshaffer
approved these changes
May 22, 2023
Hectorhammett
pushed a commit
to googleapis/google-cloud-php
that referenced
this pull request
Sep 15, 2026
Hectorhammett
pushed a commit
to googleapis/google-cloud-php
that referenced
this pull request
Sep 16, 2026
bshaffer
pushed a commit
that referenced
this pull request
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See googleapis/google-cloud-php#9715
I interpret it as having no nbf claim set. So it was always intended as a fallback.