Skip to content

fix: only check iat if nbf is not used - #493

Merged
bshaffer merged 2 commits into
googleapis:mainfrom
croensch:issue-475
May 23, 2023
Merged

bshaffer merged 2 commits into
googleapis:mainfrom
croensch:issue-475

Conversation

@croensch

@croensch croensch commented Mar 5, 2023

Copy link
Copy Markdown

See googleapis/google-cloud-php#9715

and haven't correctly used the nbf claim

I interpret it as having no nbf claim set. So it was always intended as a fallback.

@bshaffer bshaffer added the v7.0 label May 3, 2023

@bshaffer bshaffer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we did this, we would also want to support validation of the nbf claim

@bshaffer bshaffer removed the v7.0 label May 3, 2023
@croensch

Copy link
Copy Markdown
Author

If we did this, we would also want to support validation of the nbf claim

Sorry i don't understand. The nbf claim is already and will still be validated before this one.

@bshaffer

Copy link
Copy Markdown
Collaborator

You're right, I didn't realize we were checking nbf before iat. My mistake

@bshaffer bshaffer changed the title only check iat if nbf is not used fix: only check iat if nbf is not used May 22, 2023
@bshaffer
bshaffer merged commit 398ccd2 into googleapis:main May 23, 2023
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 15, 2026
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 16, 2026
bshaffer pushed a commit that referenced this pull request Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants