Skip to content

fix: handle invalid http responses - #508

Merged
bshaffer merged 5 commits into
mainfrom
handle-bad-http-response
Jun 14, 2023
Merged

bshaffer merged 5 commits into
mainfrom
handle-bad-http-response

Conversation

@bshaffer

Copy link
Copy Markdown
Collaborator

fixes #499

Comment thread src/CachedKeySet.php Resolved
Co-authored-by: croensch <christoph.roensch@arcor.de>
@bshaffer bshaffer self-assigned this Jun 14, 2023
@bshaffer bshaffer added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jun 14, 2023

@yash30201 yash30201 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seemed fine, just a small comment regarding test.

Comment thread tests/CachedKeySetTest.php Resolved
@bshaffer
bshaffer merged commit 91c39c7 into main Jun 14, 2023
@bshaffer
bshaffer deleted the handle-bad-http-response branch June 14, 2023 19:26
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 15, 2026
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 16, 2026
bshaffer added a commit that referenced this pull request Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CachedKeySet does not check HTTP response status code

4 participants