Skip to content

fix: BeforeValidException message for decode - #526

Merged
bshaffer merged 1 commit into
mainfrom
differentiate-errors
Jul 14, 2023
Merged

bshaffer merged 1 commit into
mainfrom
differentiate-errors

Conversation

@vishwarajanand

@vishwarajanand vishwarajanand commented Jul 14, 2023 •

Copy link
Copy Markdown

Addresses #514

BEGIN_COMMIT_OVERRIDE
fix: different BeforeValidException messages for nbf and iat (#526)
END_COMMIT_OVERRIDE

@vishwarajanand
vishwarajanand marked this pull request as ready for review July 14, 2023 14:16
@bshaffer

bshaffer commented Jul 14, 2023 •

Copy link
Copy Markdown
Collaborator

@vishwarajanand as there is no "bug" here, this should be considered a "chore" instead of a "fix"

Now I see that this is to differentiate between iat and nbf, not just to add a better exception message. My mistake, I agree now that it is a fix!

@bshaffer bshaffer changed the title fix: BeforeValidException message for decode chore: BeforeValidException message for decode Jul 14, 2023
@bshaffer
bshaffer merged commit 0a53cf2 into main Jul 14, 2023
@bshaffer
bshaffer deleted the differentiate-errors branch July 14, 2023 17:49
@bshaffer bshaffer changed the title chore: BeforeValidException message for decode fix: BeforeValidException message for decode Jul 14, 2023
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 15, 2026
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants