Skip to content

fix: ensure ratelimit expiry is set every time - #556

Merged
bshaffer merged 6 commits into
mainfrom
fix-ratelimit-expiry
May 18, 2024
Merged

bshaffer merged 6 commits into
mainfrom
fix-ratelimit-expiry

Conversation

@bshaffer

Copy link
Copy Markdown
Collaborator

fixes #543

Without setting the cached item expiry every time, the expiry is not persisted. In order to address this, we cache an array instead of an integer for the rate limit in the CachedKeySet class.

Comment thread src/CachedKeySet.php Resolved

@ajupazhamayil ajupazhamayil left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

@bshaffer
bshaffer merged commit 09cb208 into main May 18, 2024
@bshaffer
bshaffer deleted the fix-ratelimit-expiry branch May 18, 2024 18:03
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 15, 2026
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rate limit cache expiration is not working as expect in CachedKeySet.php

4 participants