Skip to content

fix: readme or documentation about decoding jwt - #569

Merged
bshaffer merged 2 commits into
googleapis:mainfrom
SySafarila:main
Apr 9, 2025
Merged

bshaffer merged 2 commits into
googleapis:mainfrom
SySafarila:main

Conversation

@SySafarila

Copy link
Copy Markdown

fixing typo on Readme about JWT Decode parameter from $payload to $jwt.

before fixed:

JWT::decode($payload, $key);

after fixed:

JWT::decode($jwt, $key);

@google-cla

google-cla Bot commented Jun 23, 2024

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@SySafarila

Copy link
Copy Markdown
Author

Hello, my name is Syahrul Safarila. I just reading the Readme and find out that some documentation about decoding JWT are need variable called $payload instead of $jwt.

i hope this pull request can help other developers to understand required parameter for decoding JWT.

@SySafarila SySafarila changed the title Update README.md fix: readme or documentation about decoding jwt Jun 23, 2024
@bshaffer

Copy link
Copy Markdown
Collaborator

Hi @SySafarila ! Thanks for your contribution, this looks great!

Before we can merge it, you will need to sign our Contributor License Agreement (CLA). All contributors must be covered under a CLA for them to contribute to our open source repositories.

Please visit https://cla.developers.google.com/. Once you've signed, follow the "New Contributors" link at the bottom of that page to update this check.

Thanks again!

@SySafarila

Copy link
Copy Markdown
Author

hi @bshaffer !, I have registered on the CLA already, and its look like just need a reviewer for this pull request to get merge

fixing typo on JWT Decode parameter from $payload to $jwt
@bshaffer
bshaffer merged commit 27179e1 into googleapis:main Apr 9, 2025
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 15, 2026
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 16, 2026
bshaffer pushed a commit that referenced this pull request Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants