Skip to content

fix: support php 8.4 - #583

Merged
bshaffer merged 1 commit into
googleapis:mainfrom
ruudk:php84
Nov 24, 2024
Merged

bshaffer merged 1 commit into
googleapis:mainfrom
ruudk:php84

Conversation

@ruudk

@ruudk ruudk commented Nov 24, 2024 •

Copy link
Copy Markdown

Adds PHP 8.4 to the CI matrix.

See #572 and #578

This is marked as deps so that release-please picks it up.

The previously added support for PHP 8.4 was done as chore and therefore not released.

Adds PHP 8.4 to the CI matrix.

See googleapis#572 and googleapis#578
@ruudk

ruudk commented Nov 24, 2024

Copy link
Copy Markdown
Author

@bshaffer Could you approve the workflow so that we can merge (and release) it? Thanks 🙏

@sbuerk

sbuerk commented Nov 24, 2024

Copy link
Copy Markdown

not sure if deps would lead to a release (don't know release-please) ... not that we have the same issue with the pr because it was only chore.

@bshaffer bshaffer changed the title deps: Support PHP 8.4 fix: support php 8.4 Nov 24, 2024
@bshaffer
bshaffer enabled auto-merge (squash) November 24, 2024 10:03
@bshaffer

Copy link
Copy Markdown
Collaborator

Hmm, I will need to look into why the static analysis tests are failing

@ruudk

ruudk commented Nov 24, 2024

Copy link
Copy Markdown
Author

According to the release please docs it also does a release for deps

@ruudk

ruudk commented Nov 24, 2024

Copy link
Copy Markdown
Author

Hmm, I will need to look into why the static analysis tests are failing

I can fix it, but it happens because PHPStan is not pinned. So this will keep happening because of that.

@bshaffer bshaffer mentioned this pull request Nov 24, 2024
@bshaffer
bshaffer disabled auto-merge November 24, 2024 11:03
@bshaffer
bshaffer merged commit e3d68b0 into googleapis:main Nov 24, 2024
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 15, 2026
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 16, 2026
bshaffer pushed a commit that referenced this pull request Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants