You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 5, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Sep 5, 2023. It is now read-only.
In the generated docs, the tables containing "applicable previous versions" are not rendered correctly, while in the source markdown file UPGRADING.md they are rendered just fine.
I can see the well formatted html page being generated with Sphinx for HTML. With the existing tools it doesn't seem like I can pull that page nicely for cloud.google.com. I'll have to add some feature support from Sphinx to the plugin, will get back to this in few days.
Honestly, I'm not sure this is worth the effort — I'm considering instead rolling back the changes that originally caused the funky formatting (the insertion of a formatted table) and instead just presenting that content in text since it's relatively simple. That would require undoing #268 and the related change in synthtool googleapis/synthtool#1285 but might be easier than the remaining work. Thoughts?
I filed bug 212403496 internally to handle the Sphinx formatting issues in general. For now, passing back to @meredithslota to tackle reverting the Markdown -> ReStructured Text conversion and removing the problematic tables.
Activity
docs: attempt to fix table layout
docs: attempt to fix table layout (#249)
meredithslota commentedon Nov 4, 2021
Not yet closed, let's wait to see if the change actually makes it's way through. :)
10 remaining items
tswast commentedon Dec 1, 2021
Thanks @dandhlee
I'll pass back to you once I solve the Owlbot issue with #268
dandhlee commentedon Dec 1, 2021
I can see the well formatted html page being generated with Sphinx for HTML. With the existing tools it doesn't seem like I can pull that page nicely for cloud.google.com. I'll have to add some feature support from Sphinx to the plugin, will get back to this in few days.
meredithslota commentedon Dec 23, 2021
Honestly, I'm not sure this is worth the effort — I'm considering instead rolling back the changes that originally caused the funky formatting (the insertion of a formatted table) and instead just presenting that content in text since it's relatively simple. That would require undoing #268 and the related change in synthtool googleapis/synthtool#1285 but might be easier than the remaining work. Thoughts?
tswast commentedon Dec 23, 2021
IMO, Cloud RAD really needs to support full Sphinx formatting. I don't believe this is the only doc that has been excluded for this reason.
tswast commentedon Dec 28, 2021
I filed bug 212403496 internally to handle the Sphinx formatting issues in general. For now, passing back to @meredithslota to tackle reverting the Markdown -> ReStructured Text conversion and removing the problematic tables.
meredithslota commentedon Jan 11, 2022
Reopening just to remind me to confirm that this actually fixes the issue.
meredithslota commentedon Jan 14, 2022
Confirmed fixed as of 3.6.2 release HUZZAH.