Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

docs: fixing upgrading guide v2 - #277

Merged
meredithslota merged 10 commits into
mainfrom
fixing-upgrading-guide-v2
Jan 10, 2022
Merged

meredithslota merged 10 commits into
mainfrom
fixing-upgrading-guide-v2

Conversation

@meredithslota

Copy link
Copy Markdown
Contributor

Removed formatted tables (reverts #114)
Converted file back to .MD (reverts part of #268)
Fix link to file

Fixes #153 🦕

Removed formatted tables (reverts #114)
Converted file back to .MD (reverts part of #268)
@meredithslota
meredithslota requested a review from a team January 4, 2022 20:33
@meredithslota meredithslota changed the title Fixing upgrading guide v2 docs: fixing upgrading guide v2 Jan 4, 2022
@product-auto-label product-auto-label Bot added the api: datacatalog Issues related to the googleapis/python-datacatalog API. label Jan 4, 2022
@meredithslota
meredithslota requested a review from a team as a code owner January 4, 2022 20:36
@meredithslota
meredithslota requested a review from engelke January 4, 2022 20:36
@meredithslota

Copy link
Copy Markdown
Contributor Author

I do not totally understand why the Owlbot changes got bundled into this PR.

@dandhlee dandhlee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be that owlbot updates unfroze and trying to put updates in. LGTM for just formatting update though.

@meredithslota meredithslota added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2022
@meredithslota

meredithslota commented Jan 6, 2022 •

Copy link
Copy Markdown
Contributor Author

Owlbot changes were merged in a separate PR so we are back down to just formatting changes. :)

@meredithslota meredithslota added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2022
@meredithslota
meredithslota requested review from tswast and removed request for engelke January 7, 2022 22:06
Comment thread docs/index.rst Resolved
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 8, 2022
@meredithslota
meredithslota merged commit 76f152a into main Jan 10, 2022
@meredithslota
meredithslota deleted the fixing-upgrading-guide-v2 branch January 10, 2022 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datacatalog Issues related to the googleapis/python-datacatalog API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect rendering of tables in the docs

5 participants