Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

Fix type of get_all gRPC call #125

Closed

Description

@rafilong

The type for the generated batch_get_all is AsyncIterable[firestore.BatchGetDocumentsResponse], but was incorrectly mocked as Iterable[firestore.BatchGetDocumentsResponse].

Activity

  1. added this to the AsyncIO Client milestone on Jul 22, 2020
  2. self-assigned this
    on Jul 22, 2020
  3. crwilcox commented on Jul 23, 2020

    @crwilcox
    Contributor
  4. rafilong commented on Jul 23, 2020

    @rafilong
    ContributorAuthor

    Sorry, I just realized my description was a bit misleading. The incorrectly mocked type was in the Firestore test I wrote to test get_all, in which I was mocking the return type of batch_get_all. The generated code functioned fine, my use of it was slightly flawed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: firestoreIssues related to the googleapis/python-firestore API.triage meI really want to be triaged.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions