This repository was archived by the owner on May 14, 2026. It is now read-only.
Repository navigation
feat: autopopulate fields in the request - #2353
Merged
Merged
Conversation
alicejli
marked this pull request as ready for review
January 23, 2024 19:59
lqiu96
reviewed
Jan 30, 2024
lqiu96
reviewed
Jan 30, 2024
alicejli
commented
Jan 31, 2024
alicejli
commented
Jan 31, 2024
alicejli
commented
Jan 31, 2024
alicejli
commented
Jan 31, 2024
blakeli0
approved these changes
Jan 31, 2024
blakeli0
left a comment
Contributor
There was a problem hiding this comment.
LGTM. In follow up PRs, please extract the golden unit test cases to a separate proto/yaml.
lqiu96
approved these changes
Jan 31, 2024
…pic/model/FieldTest.java Co-authored-by: Blake Li <blakeli@google.com>
…ableTest.java Co-authored-by: Blake Li <blakeli@google.com>
|
Please retry analysis of this Pull-Request directly on SonarCloud |
|
alicejli
added a commit
that referenced
this pull request
Feb 8, 2024
As a clean-up follow up to #2353, this PR refactors the unit golden tests for the autopopulation feature to a separate, new proto called `auto_populate_field_testing.proto`.
ddixit14
pushed a commit
that referenced
this pull request
Feb 15, 2024
* feat: autopopulate fields in the request * revert showcase golden changes * add AbstractTransportServiceStubClassComposerTest * add REST implementation * add GrpcDirectCallableTest * remove unnecessary null check * add field info proto registry and more unit test cases * add HttpJsonDirectCallableTest * refactor AbstractTransportServiceSTubClassComposer * add more unit tests for Field * feat: refactor request mutator expression * fix goldens * add showcase test for autopopulation * fix lint * change assertion in showcase test * refactor for sonarcloud * sonarcloud fixes * sonarcloud * sonarcloud fix * fix sonarcloud * slight refactoring * revert changes to directCallable and replace with retryable Callable * overload retrying Callables method * change license header format * fix license header * fix showcase lint * add comment * add showcase comment * add CallableTest and httpjson Retrying test * fix lint * add RetryingCallable test and some refactoring * refactor GrpcCallableFactory * remove extraneous from HttpJsonDirectCallableTest * remove FakeHttpJsonChannel * revert changes to tests for extra param * refactoring * Update gapic-generator-java/src/test/java/com/google/api/generator/gapic/model/FieldTest.java Co-authored-by: Blake Li <blakeli@google.com> * Update gax-java/gax/src/test/java/com/google/api/gax/rpc/RetryingCallableTest.java Co-authored-by: Blake Li <blakeli@google.com> --------- Co-authored-by: Blake Li <blakeli@google.com>
ddixit14
pushed a commit
that referenced
this pull request
Feb 15, 2024
As a clean-up follow up to #2353, this PR refactors the unit golden tests for the autopopulation feature to a separate, new proto called `auto_populate_field_testing.proto`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to: #2312
This adds autopopulation of fields within the Request message for protos that are configured. This currently only supports UUID4.