Repository navigation
Conversation
… Truth, and android-maps-testing - Add 76 host-side unit, Robolectric, and deterministic golden screenshot tests across navigation-sample (37 tests) and map-sample (39 tests), plus 6 connected-device smoke and AI visual tests (82 total tests across 15 suites). - Configure org.jetbrains.kotlin.plugin.power-assert with android-maps-testing Power-Assert extensions (assertGeo, assertMap, assertMarker) for Kotlin tests and Google Truth + MapsTruth subjects for Java tests. - Record and commit 5 deterministic golden baseline PNGs under src/test/resources/goldens/ using com.google.maps.android:maps-testing-golden. - Fix nullable view parameter in CustomizationPanelsDelegate.OnItemSelectedListener.onItemSelected when Spinner selection fires while panel is hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a 3-tier testing pyramid across both standalone projects in this repository (
navigation-samplein Kotlin/Java andmap-samplein Java), totaling 82 automated tests across 15 test suites (76fast host-side JVM, Robolectric, and deterministic golden screenshot tests +6connected-device smoke and AI visual tests):71tests /9suites):org.jetbrains.kotlin.plugin.power-assertalongsidecom.google.maps.android:maps-testing-robolectric:1.0.0-rc01Power-Assert extensions (assertGeo,assertMap,assertMarker,distanceTo,meters,isCenteredOn,connects,hasVertexNear,contains) for Kotlin tests.Truth.assertThat) andMapsTruth.assertThat(map)domain subjects for Java code and Java-to-Kotlin interop tests (LayoutDelegatesJavaTest.java,MapUtilitiesJavaTest.java,MapActivitiesTruthTest.java).5tests /2suites):com.google.maps.android:maps-testing-golden:1.0.0-rc01(enableGoldenTesting,GoldenTileStrategy,assertMatchesGolden,hasOverlayPixelAt) with 5 recorded and committed.pngbaseline images undersrc/test/resources/goldens/.6tests /4suites):AndroidJUnit4, Google Truth, andcom.google.maps.android:maps-testing-visual:1.0.0-rc01(BaseVisualTest+verifyScreenshotWithGoldenFallback) inNavigationSampleSmokeTest.kt,NavigationVisualTest.kt,MapSampleSmokeTest.java, andMapSampleVisualTest.kt.NullPointerExceptioninCustomizationPanelsDelegate.ktwhereAdapterView.OnItemSelectedListener.onItemSelecteddeclared a non-nullview: Viewparameter (which isnullwhenSpinner.setSelectionfires while a customization panel is hidden).Verification
cd navigation-sample && ./gradlew testDebugUnitTest lintDebug assembleDebugAndroidTest(37/37unit/Robolectric/Golden tests passing,0lint/compile errors)cd map-sample && ./gradlew testDebugUnitTest lintDebug assembleDebugAndroidTest(39/39unit/Robolectric/Golden tests passing,0lint/compile errors)