Repository navigation
fix(ci): publish a version-tagged image for each release - #834
Draft
MoonBoi9001 wants to merge 2 commits into
Draft
MoonBoi9001 wants to merge 2 commits into
MoonBoi9001 wants to merge 2 commits into
Conversation
A tag pushed with the workflow token starts no workflow, so no release ever built an image tagged with its version, and k8s/deployment.yaml named one that does not exist. The release workflow now starts the image build on each new tag, which leaves `latest` and `sha-` alone.
Quotes the GitHub file variables that runs write to, and marks the 1 place where a list is meant to split into separate arguments, so actionlint passes on every workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No release has ever published an image tagged with its version, because a tag pushed with the workflow token starts no workflow, so
k8s/deployment.yamlnames an image that does not exist. The release workflow now starts the image build on each new tag, and that build leaveslatestand thesha-tag alone.Important
Merge this before the 0.3.0 release PR (#829), or 0.3.0 will also ship without a version-tagged image.