Skip to content

website demo Doesn't work on mobile #1413

Closed

Description

@linhtranvu

Subject of the issue

Test on both iphone and android phone, none work

Your environment

  • Run demo on websie
  • Iphone and Android chrome

Steps to reproduce

Use phone to visit gridstackjs website

Expected behaviour

Demo should run

Actual behaviour

No demo work. So current library do not support mobile browser
F6547577-74AD-4F38-ABA6-10E2C27C3C87

Activity

  1. adumesny commented on Oct 16, 2020

    @adumesny
    Member

    likely that touch lib isn't used on the website... I have not tested mobile, but it used to work I was told. Will have to take a look.

  2. naturtrunken commented on Oct 24, 2020

    @naturtrunken

    Can confirm that it does not work. Tested on iPadOS 14.0.1 and iOS 12.4.8 and 14.0.1.

    The hint about using the touch-punch.js didn't worked for me first. The original repo was not updated since 2014. However, I tried the newer fork from https://github.com/RWAP/jquery-ui-touch-punch - which also didn't worked. It throwed an error in the console that it could not find jquery.ui.

    But JQuery UI is included in gridstack and was indeed loaded. So, I tried to remove the definition from the jquery.ui.touch-punch.js file (from the new repo) in line 22 and then it worked on all my mobile systems.

    It seems for me, that although JQuery UI is loaded, it cannot be found via "jquery.ui" string. I'm not deep enough into JS to understand why this is here the case.

  3. adumesny commented on Oct 24, 2020

    @adumesny
    Member

    @naturtrunken thanks! I might just need to include a patched touch-punch file along with jquery-ui to make it work out of the box (and update the live site).

  4. whazlewo commented on Nov 13, 2020

    @whazlewo

    I came here to see if this was a known issue. I'm glad there is a solution! Any idea when an update may be available? I'm hyped to incorporate this into a prototype I'm working on.

  5. adumesny commented on Nov 13, 2020

    @adumesny
    Member

    @tobias-grasse I know you're using touch-punch.js with no issues so curious what version/fixes you had to make.

    I’ve been using Gridstack inside a Vue.js app that focuses on mobile-first, no complaints here. You’ll likely have to tweak the CSS and there’s a limit to usability on smaller screens, but that’s a plain physical constraint

  6. linhtranvu commented on Nov 16, 2020

    @linhtranvu
    Author

    To be honest return back to a jQuery version is more stable. I am using 0.6.4 and it really good

  7. adumesny commented on Nov 16, 2020

    @adumesny
    Member

    @linhtranvu there is no reason you can't use the latest, which still uses jqueryui for drag&drop only (heck even upcoming 3.0 which will have a new html5 native drag&drop will also support legacy jquery-ui if you want). v0.6.4 is 400+ commits behind the latest :)
    https://github.com/gridstack/gridstack.js/releases/tag/v0.6.4

  8. aryatekpia commented on Dec 1, 2020

    @aryatekpia

    I am still having issue with grids having very small height on mobile. I am using gridstack.all.js according to the documentation. I also added jquery-ui-touch-punch but unlike @naturtrunken I am not getting any error in the console but the height issue on mobile devices is not fixed.

    Any advise will be appreciated.

  9. adumesny commented on Dec 1, 2020

    @adumesny
    Member

    @aryatekpia you can set cellHeight yourself to control the row height... recommend you use the latest 3.0.0 (use gridstack-jq.js which is the same as all.js was)

  10. aryatekpia commented on Dec 1, 2020

    @aryatekpia

    Thanks @adumesny for your prompt reply. playing with cellHeight and setting it to something like this grid.cellHeight(grid.cellWidth() * 1.2); fixes the hight on mobile however the problem is that it messes up the x,y position resulting on the grid items to lay on top of each other.

  11. adumesny commented on Dec 1, 2020

    @adumesny
    Member

    @aryatekpia please file a separate bug as this is likely NOT a mobile issue, but a oneColumnMode and how you init your grid, or missing some CSS, or... with reproduceable case. If boxes overlap, it's a CSS issue.

  12. aryatekpia commented on Dec 2, 2020

    @aryatekpia

    okey thanks I will try to make reproduceable demo.

  13. changed the title [-]Dont work on mobile browser[/-] [+]website demo Doesn't work on mobile[/+] on Dec 5, 2020
  14. pinned this issue on Jan 3, 2021
  15. davidh07 commented on Jan 24, 2021

    @davidh07

    Great product. Any idea when the mobile version will be working. Also how do you get the js files from the downloads. It's not clear. Is there a cdn?
    Thanks

  16. adumesny commented on Jan 24, 2021

    @adumesny
    Member

    @davidh07 read the doc about npm installing. As for fixing, I have to setup mobile dev testing which I have not done before...

  17. added 2 commits that reference this issue on Jan 25, 2021
  18. unpinned this issue on Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions