Skip to content

Fix retries that timeout hanging forever. #10855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larry-safran merged 2 commits into from
Jan 31, 2024
Merged

Fix retries that timeout hanging forever. #10855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3130739
Fix retries that timeout hanging forever.
larry-safran Jan 27, 2024
a8804c5
Merge branch 'grpc:master' into retry_timeout
larry-safran Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/java/io/grpc/internal/RetriableStream.java
View file
Open in desktop

@sergiitk sergiitk Jan 29, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test to cover this case?

@larry-safran larry-safran Jan 30, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out that due to mocks it is difficult.

Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,10 @@ public void run() {
}
}
if (retryFuture != null) {
retryFuture.cancel(false);
boolean cancelled = retryFuture.cancel(false);
Comment thread
sergiitk marked this conversation as resolved.
if (cancelled) {
inFlightSubStreams.decrementAndGet();
}
}
if (hedgingFuture != null) {
hedgingFuture.cancel(false);

@YifeiZhuang YifeiZhuang Jan 30, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks hedging also has the same problem.
A UT would be really helpful in either retry or hedging cases.

Expand Down