Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not review
This change re-writes some tests (as well as the
any_grpc.jshelper file) to test the pure js client against the native server. It should fail until a few pending PRs (#128, #131, #132, and two other future ones) are landed.Skipped tests
Tests for Google credentials and deadline propagation are currently skipped for the JS client.
large removals in
credentials_test.jsandsurface_test.jsThe large removal in
credentials_test.jsis code I had previously copied intocredentials_api_test.jsand forgotten to delete.The large removal in
surface_test.jsis what is nowsurface_server_test.js.any_grpc.jsI've changed this file to export
requireAs*andrunAs*(* means either client or server) functions. The former functions asrequirebut any nested calls torequire('grpc')will be intercepted to return the relevant implementation instead. The latter simply takes a function and runs it with a single argument, which is the relevant grpc implementation. This is primarily useful for separating client and server implementations in the same scope, as I can turninto
This allows us to change tests back to using
require('grpc')and be relatively unencumbered by changes specific to dual implementations of grpc.