Skip to content

L13: gRPC Python Client and Server Interceptors - #39

Closed
mehrdada wants to merge 2 commits into
grpc:masterfrom
mehrdada:python-interceptors
Closed

mehrdada wants to merge 2 commits into
grpc:masterfrom
mehrdada:python-interceptors

Conversation

@mehrdada

@mehrdada mehrdada commented Oct 2, 2017 •

Copy link
Copy Markdown
Contributor

@hsaliak

hsaliak commented Feb 2, 2018

Copy link
Copy Markdown
Contributor

@nathanielmanistaatgoogle please approve so that this proposal can be merged in a timely manner.

@mehrdada

mehrdada commented Feb 2, 2018

Copy link
Copy Markdown
Contributor Author

I need to make modifications to it. The API has somewhat changed. Please hold off on reviewing it. I have not forgotten.

@naggie

naggie commented Feb 2, 2018 •

Copy link
Copy Markdown

After following about 6 links in various PRs and issues around the same change, I'm confused about the status of this interceptor feature -- is it already in 1.8.x? -- I see it in the release notes for v1.8.0

Thanks for the work on this feature, it will allow me to remove considerable boilerplate.

@mehrdada

mehrdada commented Feb 2, 2018

Copy link
Copy Markdown
Contributor Author

@naggie Yes, we pursued this proposal and captured some user feedback and an experimental version (which will very likely become final after marking this proposal as approved) is merged already and is ready to use. I still need to update this proposal to incorporate the feedback and update it to match the version that we shipped since 1.8.

@dfawley

dfawley commented Oct 24, 2018

Copy link
Copy Markdown
Member

For consistency, please rename this file to L13-python-... before merging. Thanks!

@lidizheng

Copy link
Copy Markdown
Contributor

@mehrdada Can you take some time to update the server interceptor section to match the implementation? We want to make interceptor API stable, and it will be great to make this gRFC a reference of its rationale/design.

@mehrdada

mehrdada commented Jan 12, 2019 •

Copy link
Copy Markdown
Contributor Author

@lidizheng I don't think I am going to have any free time to spend on that, sorry. Feel free to fork it and make it your own; I don't mind. Just to point out one thing you need to figure out that users have asked for is (my memory is a bit fuzzy but it has to be somewhere in the issues) how the interceptors can detect whether an exception thrown is an abortion or not, if I remember correctly.

@mehrdada mehrdada closed this Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants