Skip to content

Coordinate PULL REQUESTs #67

Closed
Closed

Description

@gsscoder

Dear actual or future contributors,
due to deep changes to command line parser kernel, I'm not able to accept PR without previous coordination.

This is true for both master and devel-* branch.

This is a general good rule, but in this case is a key necessity.

PR are always welcome, but when there are such ongoing change -> merging could be difficult (or impossible) and so coordination is required.

Hope this don't stop you from sending PR.

develop-* branch:

  • Even if some good refactoring occured in that branch, my attempt to transform the kernel in something new ended up in over-engineering when solving old code smells created new code smells (there's nothing to hide, this is the truth).
  • I'm drafting the new kernel outside the project repo for explore new possibilities. Expect this work to become master ASAP.

Giacomo Stelluti Scala

PS: this guide helped me, but don't take the title as statement of mine (http://goo.gl/xJFE1) -> read it!

Activity

  1. gsscoder commented on Mar 6, 2013

    @gsscoder
    OwnerAuthor

    Why the kernel is under heavy refactoring? This is done for following reasons:

    • enhance extensibility
    • enhance maintainability (adding feature will be a lot easier)
    • enhance robustness
    • simplify as more as possible the codebase
    • simplify as more as possible the test codebase (ahh...)

    Gains? Implicit in points.

    Finality: give everyone an even better library... ;))

  2. hanson-andrew commented on Jun 12, 2013

    @hanson-andrew

    I'm somewhat confused as to where this project stands now. Are you currently accepting pull requests as long as you're aware of them beforehand or is the refactoring work still ongoing?

  3. nemec commented on Jun 12, 2013

    @nemec
    Collaborator

    @hanson-andrew it doesn't look like the code has been worked on recently, so it's probably as stable as it's going to get right now.

    I'd recommend bringing up any possible new features in an Issue to get some feedback first, though.

  4. hanson-andrew commented on Jun 12, 2013

    @hanson-andrew

    Will do. I just wanted to make sure as it seemed like more work might be incoming. Thanks!

  5. gsscoder commented on Jun 10, 2015

    @gsscoder
    OwnerAuthor

    This discussion is now superseded, a lot of PRs has been merged. I close this issue/announcement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions