Repository navigation
fix(coaching): confirm paid sessions and show registrations - #149
Open
RenaudBernier wants to merge 1 commit into
Open
RenaudBernier wants to merge 1 commit into
RenaudBernier wants to merge 1 commit into
Conversation
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117
Overview
Private lessons stayed pending after successful checkout, and the service's Registrations page only queried program bookings. Completed coaching checkout now sets the booking to confirmed, expires the registrations cache, and shows private lessons in the service's registration list. The existing payment-state guard and single coordinator notification are preserved.
Testing
pnpm test:ci --runInBand: 109 tests passed across 14 suites, including webhook confirmation/retries, adult and child registrations, program compatibility, and the Confirmed badge.pnpm lint: passed with 12 existing warnings; changed TypeScript files pass focused lint.pnpm exec tsc --noEmit: blocked by existing TS2556 errors in__tests__/children-actions.test.ts:37and__tests__/children-admin-actions.test.ts:36.Screenshots / Screencasts
Registration rendering is covered by the component test. Live Stripe checkout was not exercised.
Checklist
Notes
This confirms new paid bookings; it does not assign a time. The existing availability-window flow still leaves scheduling to the coach. Existing pending rows are not migrated.