Skip to content

removing superfluous config parameters for template files - #947

Closed
ccoenen wants to merge 1 commit into
hackmdio:masterfrom
ccoenen:direct-templates
Closed

ccoenen wants to merge 1 commit into
hackmdio:masterfrom
ccoenen:direct-templates

Conversation

@ccoenen

@ccoenen ccoenen commented Sep 10, 2018

Copy link
Copy Markdown
Contributor

All those pages still work, but now we're actually making use of

codimd/app.js

Line 170 in 0017ddd

app.set('views', path.join(__dirname, '/public/views'))

@SISheogorath

Copy link
Copy Markdown
Contributor

We shouldn't use the app.set statement here. Or at least, make it configurable by config like we do it with the current view elements instead of having it statically using __dirname inside the code. Otherwise I agree that this makes it a lot simplier to render things :)

@SISheogorath SISheogorath added the enhancement Wants to improvide an existing feature label Sep 11, 2018
@SISheogorath SISheogorath added this to the 1.3.0 release milestone Sep 11, 2018
Signed-off-by: Claudius <opensource@amenthes.de>

@SISheogorath SISheogorath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccoenen

ccoenen commented Oct 6, 2018

Copy link
Copy Markdown
Contributor Author

commit is already contained in #940 (rebased bb80bc2)

@ccoenen ccoenen closed this Oct 6, 2018
@ccoenen
ccoenen deleted the direct-templates branch November 2, 2018 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Wants to improvide an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants