Skip to content

Don't depend on zlib.dll on windows. - #12274

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
AndreasPK:apk/fix-win-zlib
Sep 6, 2026
Merged

mergify[bot] merged 1 commit into
haskell:masterfrom
AndreasPK:apk/fix-win-zlib

Conversation

@AndreasPK

Copy link
Copy Markdown
Collaborator

zlib.DLL might not be available, for example if we build in a msys env, but run under powershell. Fixes #12272


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

It might not be available, for example if we build in a msys env, but run under powershell.
Fixes haskell#12272

@Mikolaj Mikolaj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zlonast zlonast added the merge me Tell Mergify Bot to merge label Sep 2, 2026
@mergify mergify Bot added the ready and waiting Mergify is waiting out the cooldown period label Sep 2, 2026
@ffaf1

ffaf1 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

This looks uncontroversial enough to make 3.18.2.0.

@mergify mergify Bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Sep 6, 2026
@mergify

mergify Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-09-06 06:57 UTC · Rule: default · triggered by rule Put pull requests in the rebase+merge queue
  • Checks passed · on draft merge queue: checking #12274 on master (4d36130) #12325
  • Merged2026-09-06 09:04 UTC · at 6c8b290e0e056a9233bed3138cc63bdc7ebfc398 · merge

This pull request spent 2 hours 6 minutes 52 seconds in the queue, including 1 hour 56 minutes 26 seconds running CI.

Required conditions to merge
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergify
mergify Bot merged commit 6c8b290 into haskell:master Sep 6, 2026
72 checks passed
@mergify mergify Bot removed the queued label Sep 6, 2026
@ffaf1

ffaf1 commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

@mergify backport 3.18

@mergify

mergify Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

backport 3.18

✅ Backports have been created

Details

mergify Bot added a commit that referenced this pull request Sep 6, 2026
Backport #12274: Don't depend on zlib.dll on windows.
@ulysses4ever

Copy link
Copy Markdown
Collaborator

no changelog entry :-( i'm not sure Template B was the right call here.

@ulysses4ever

ulysses4ever commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

moreover, this patch only touched cabal.project, which means many peope won't benefit from it: neither cabal install cabal-install nor our release process, which uses another project file, cabal.release.project. @ffaf1 @Mikolaj ?

@Mikolaj

Mikolaj commented Sep 10, 2026

Copy link
Copy Markdown
Member

Ouch, I missed both when reviewing. @AndreasPK: would you find a moment to make an extra-quick followup PR with the same fix for the other 3 cabal.release.* files and with the tiny changelog snippet, as in all the other PRs? Or even one of the above?

@ulysses4ever

Copy link
Copy Markdown
Collaborator

the other project file (there's just one that we care about i think, cabal.release.project) is easy but do we have a plan for cabal install cabal-install? If we can't make it "just work", we probably should document it somewhere?..

@ulysses4ever ulysses4ever mentioned this pull request Sep 10, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attention: needs-backport 3.18 merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

windows: cabal-install built in msys-shell links against msys env specific dlls.

5 participants