Repository navigation
Merge upstream/main 67661cfbb5 into coder-only (sync stage 4 of 4: #26238) - #266
Merged
Merged
Conversation
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Stage 4 of the e923627 → 67661cf sync: pingdotgg#26238 alone, upstream's deletion of about 18k lines nothing reaches. Takes upstream's deletions everywhere, including the RPCs it removed (WsServerGetSettingsRpc, WsTerminalRestartRpc, WsSubscribeTerminalEvents Rpc, WsOrchestrationV2SubscribeArchivedShellRpc, WsScheduledTasksListRpc), which also leave CoderWsRpcGroup; nothing in the gateway, helper or coder-cli used them. Fork seams stay wherever their code survives. Two markers went with blocks upstream deleted: CodexAdapterV2.testkit.ts's trimmed-config note on the duplicate makeReplayServerConfig, and ws.ts's webhook note on the scheduledTasksList handler. Fork code upstream's deletions would have broken: - shared's resolveProjectAutoPull moves into the fork-only vcs/projectAutoPull.ts, which coderServer.ts and the VcsStatusBroadcaster seam still use for legacy project.autoPull. - client-runtime state/runtime.ts keeps exporting executeAtomCommand for the fork-only errors/diagnostics test. - TimelineV2EventRow returns null for link_request items now that upstream's generic fallback is gone. - ProviderSettingsPanel's ungated provider settings move under upstream's RemoteSessionGatedProviderSettings name. Also: apps/server drops the merge-reintroduced @opencode-ai/sdk and takes upstream's removal of @modelcontextprotocol/sdk; the new source-control-core pullRequestUtils.ts is carried for the GitLab driver; knip ignores its cut-host exports and shared fileLinks' desktop-only joinPath. The seams doc drops the stale "replay fixtures kept on purpose" sentence and records the moved seams. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitWorkflowService.test.ts (kept by the fork after upstream deleted it in pingdotgg#22557) checked the non-Git routing guard pingdotgg#26238 removed; it now checks only that the helper pass-throughs route through the command guard. The Kilo Code adapter test reads commands a real ACP child advertises after a delay; pingdotgg#26238 deleted that mock-agent option because no upstream test used it, so acp-mock-agent.ts keeps it as a Coder seam. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
useThreadActionMenu.test.tsx mocks readEnvironmentServerConfigLoaded, which replaced the per-capability readers pingdotgg#26238 removed, and PullRequestMarkdown.test.tsx expects the MR host the page surface now carries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 4 of the e923627 → 67661cf upstream sync: pingdotgg#26238 on its own, upstream's deletion of about 18k lines that nothing reaches. With this stage,
coder-onlyis synced through upstream 67661cf.Taken: upstream's deletions everywhere, including the RPCs it removed:
WsServerGetSettingsRpc,WsTerminalRestartRpc,WsSubscribeTerminalEventsRpc,WsOrchestrationV2SubscribeArchivedShellRpcandWsScheduledTasksListRpc. They also leaveCoderWsRpcGroup; nothing in the gateway, helper or coder-cli used them. Fork seams stay wherever their code survives. Two markers went with blocks upstream deleted: the trimmed-config note inCodexAdapterV2.testkit.ts, and thescheduledTasksListwebhook note inws.ts.Fork code the deletions would have broken (each a
Coder:seam, listed in the seams doc):resolveProjectAutoPullmoves into the fork-onlyvcs/projectAutoPull.ts, which the legacyproject.autoPullsupport still uses.state/runtime.tskeeps exportingexecuteAtomCommandfor the fork-only diagnostics test.acp-mock-agent.tskeepsT3_ACP_COMMAND_ADVERTISEMENT_DELAY_MSfor the Kilo Code adapter test.TimelineV2EventRowreturns null forlink_requestitems, since upstream's generic fallback is gone.RemoteSessionGatedProviderSettingsname.GitWorkflowServicejjguard,readEnvironmentServerConfigLoaded, and the MR surface host.Also:
apps/serverdrops the@opencode-ai/sdkthat the merge reintroduced, and takes upstream's removal of@modelcontextprotocol/sdk.pullRequestUtils.tsis carried for the GitLab driver.fileLinks' desktop-onlyjoinPath.Verification:
pnpm knip:check, the unused-locals check (empty),vp fmt --check, and the section 6 marker and lost-line checks pass. The two marker drops are the deleted blocks above.pnpm test:codersteps all pass (TMPDIR under /private/tmp): coder node tests, codex app-server, contracts, server (257 files), providers, source-control, client-runtime, shared, andtest:knip. Web passes apart from the two Tests that flake under full-suite load #236 load flakes (localApi,AttachmentFilePreview), which pass alone.pnpm buildpasses.node:24-bookworm-slim): it boots, applies migrations through 072 (070 and 071 as no-ops), and extracts document text.coder ssh, and server config withconnectionProbeadvertised.coder port-forwardstart, restart and close.kilo acpagent turn that finds the bridge, lists tools (not3_environment_link*tools) and callst3_queueover it.🤖 Generated with Claude Code