Repository navigation
Fix duplicated words and a misspelling in messages and docstrings - #14287
Conversation
|
Hi @Sreekant13, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@bot style |
|
sorry looks like the styling bot is not working at the moment, would you mind fixing the failing CI checks? |
e05915d to
4ab62e8
Compare
|
Sorry for the delay, I was in between interviews. The check_code_quality failure was ruff format: removing the duplicated word shortened those raise ValueError(...) lines enough that they now fit on one line, so the formatter wanted to collapse the wrapped form. I have run ruff format and rebased onto main, so this should be green once the workflows are approved. Thanks for the review and approval @stevhliu. |
|
hmm, looks like its still failing. can you try running |
|
Hi @Sreekant13, a follow-up on the reminder above: this PR still does not link an issue it fixes. Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice. Adding a closing keyword (e.g. |
Remove accidental repeated words in eight "must have have batch size"
error messages raised by the modular pipelines, and in two docstrings
("Dimension to to encode", "image batch to be be inpainted"). Also fix
"arbitary" to "arbitrary" in the LTX2 pipeline docstring.
Text only, no behavior change.
4ab62e8 to
b242072
Compare
|
Thanks for your patience @stevhliu. Two things were wrong on my side: I had been running a newer ruff than the pinned 0.9.10, and I had missed the doc-builder style step of make quality. That last one was the actual failure, shortening "to be be inpainted" meant the docstring paragraph needed reflowing. Fixed and pushed; make quality is clean locally now. Also, the bot has flagged this for auto-closure since there is no linked issue. As it is just a typo fix, would you be able to add the no-issue-needed label? Happy to open an issue instead if you prefer. |
|
Thanks for merging this @stevhliu, and thanks for your patience with the CI. For the record, in case it helps anyone hitting the same wall: my failure was running a newer ruff than the pinned 0.9.10, and then only running part of |
What does this PR do?
Removes accidental repeated words and fixes one misspelling. Text only, no behavior change.
Eight of these are in user-facing
ValueErrormessages raised by the modular pipelines, which currently read "must have have batch size ...":modular_pipelines/anima/before_denoise.pymodular_pipelines/helios/before_denoise.pymodular_pipelines/wan/before_denoise.pymodular_pipelines/z_image/before_denoise.pymodular_pipelines/qwenimage/inputs.pymodular_pipelines/qwenimage/before_denoise.pymodular_pipelines/stable_diffusion_3/inputs.pymodular_pipelines/flux/before_denoise.pyThe remaining three are docstrings:
models/unets/unet_spatio_temporal_condition.py: "Dimension to to encode" becomes "Dimension to encode"pipelines/flux/pipeline_flux_kontext_inpaint.py: "image batch to be be inpainted" becomes "to be inpainted"pipelines/ltx2/pipeline_ltx2_condition.py: "arbitary" becomes "arbitrary"No linked issue; this is a small text-only cleanup.
Before submitting
self-reviewskill on the diff?documentation guidelines, and
here are tips on formatting docstrings. (The docstrings themselves are what this PR corrects.)
Self-review notes
Claude Code was used to locate the typos and prepare the diff; I reviewed and verified every change myself before submitting.
Blocking issues: none. The diff is 11 files, 11 insertions, 11 deletions, each removing one repeated word or correcting one spelling. No code paths, control flow, or public signatures are touched, and no dead code is introduced.
Findings intentionally not fixed:
pipelines/visualcloze/pipeline_visualcloze_combined.pyandpipeline_visualcloze_generation.pycontain "Images are missing in in-context examples." That looks like a repeated word but is correct English ("in" followed by "in-context"), so it is left alone.dataframe-style near misses such as "cast to to avoid" were checked for and only genuine repeats were changed.Verification: all 11 changed files byte-compile, and a repeat scan of
src/for these patterns returns no remaining matches. The branch is based on currentmain(ed58810).Who can review?
@stevhliu @sayakpaul (docs and general text), since this is a documentation and message wording change.