Repository navigation
caption.js 2.3.1: a dual-speaker caption's lines are each a sentence - #294
Merged
Merged
Conversation
…f its own (hyperaudio-lite-editor#749)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hyperaudio/hyperaudio-lite-editor#749.
A one-word turn without punctuation, "This" opening "This is Marusa." after a diarizer gave the word to the other speaker, became the second line of a dual-speaker caption ("-And we're sitting at Mozfest." / "-This"). It would equally have opened one as the first line.
joinAsSecondSpeakeronly asked that the previous caption held whole sentences, which any segment that fits on one line counts as, whether punctuation or a label closed it.Each side of a dual-speaker caption is now a sentence closed by its own punctuation, by the segmenter's own test, so a fragment keeps its own caption on either side. The transcript above now gives "And we're sitting at Mozfest." / "This" / "is Marusa.", still imperfect, but no caption carries another speaker's half-word.
caption.js 2.3.1, with the type note and a test. 38 caption tests pass, 99 in all.