Repository navigation
feat(client): decouple tokio/net and mio from client-legacy - #338
Open
Aditya-9-6 wants to merge 1 commit into
Open
Aditya-9-6 wants to merge 1 commit into
Aditya-9-6 wants to merge 1 commit into
Conversation
Previously, client-legacy unconditionally enabled tokio/net, socket2, and libc, which forced the mio dependency even on platforms that do not support it (such as Fuchsia and WASM), and for downstream libraries (like hyper-rustls) that provide custom connectors without requiring TCP networking. This change: - Re-introduces the tcp feature ([tokio, tokio/net, dep:socket2, dep:libc]) matching hyper 0.14 convention. - Decouples tokio/net, socket2, and libc from client-legacy. - Gates HttpConnector, dns, and build_http behind #[cfg(feature = tcp)]. - Adds tcp to the full feature shorthand. - Adds an integration test ensuring client-legacy works with a custom connector without requiring the tcp feature. Closes hyperium/hyper#3842
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, client-legacy unconditionally enabled tokio/net, socket2, and libc, which forced the mio dependency even on platforms that do not support it (such as Fuchsia and WASM), and for downstream libraries (like hyper-rustls) that provide custom connectors without requiring TCP networking.
This change:
Closes hyperium/hyper#3842