Skip to content
This repository was archived by the owner on Mar 1, 2024. It is now read-only.
This repository was archived by the owner on Mar 1, 2024. It is now read-only.

invalid output from deflate_medium #2

Closed

Description

@jsnell

The deflate_medium strategy occasionally produces outputs that are corrupt in various ways. The archive http://jsnell.iki.fi/tmp/deflate-medium-testcase.tar.gz has a minimal test case. The result of running it against this zlib at level 5 can't be decompressed, but can be if run at level 9. Likewise decompressing the output works with baseline zlib at all levels.

This test case has been heavily pruned from a much larger one. I'm hoping there's just one bug here, but it's possible there are multiple, since the behavior is occasionally different with the larger test cases. (I can't really direct the automated pruning process in any way, so if there are multiple issues, creating a minimal test case would require that this issue be fixed).

Activity

  1. self-assigned this
    on May 5, 2014
  2. jtkukunas commented on May 5, 2014

    @jtkukunas
    Contributor

    Sorry for the delay in responding ...

    I can reproduce the issue with your testcase. Interestingly, it doesn't occur when decompressing with minigzip or gzip, as opposed to openssl. I'll investigate and get back to you.

    Thanks.

  3. joshtriplett commented on Jun 2, 2014

    @joshtriplett

    Any progress tracking down the issue?

  4. jtkukunas commented on Jun 3, 2014

    @jtkukunas
    Contributor

    Yeah, I tracked the issue down to an edge case, triggered by the sync flush in the testcase, where we would update the hash with invalid data.

    jsnell,

    I've pushed a branch, issue2, that should resolve the issue. Can you confirm whether this fixes the bug for you? Specifically, commit ef27907.

    Thanks.

  5. jsnell commented on Jun 3, 2014

    @jsnell
    Author

    Thanks, that fixes my problem.

  6. added a commit that references this issue on Jun 16, 2014
    4fc7abb
  7. added a commit that references this issue on Jul 26, 2014
    0a225b1
  8. added a commit that references this issue on Jun 21, 2018
    d6a0d5f
  9. added 2 commits that reference this issue on Jan 26, 2022
    7133327
    5d53972
  10. added a commit that references this issue on Apr 15, 2022
    db2aa92
  11. added a commit that references this issue on Apr 25, 2022
    01d45a6
  12. added a commit that references this issue on Aug 29, 2022
    ffa14f9
  13. added a commit that references this issue on Nov 9, 2022
    9adc941
  14. added a commit that references this issue on Nov 19, 2023
    960eb54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions